Skip to content

Commit d19ded5

Browse files
authored
firmware/ev3: Don't request hardware version.
This feature doesn't seem to work when it is issued from a USB3 bus. See pybricks/support#2515. Since we don't use the version, removing the command is harmless.
1 parent 0d0e366 commit d19ded5

1 file changed

Lines changed: 0 additions & 22 deletions

File tree

src/firmware/sagas.ts

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1211,28 +1211,6 @@ function* handleFlashEV3(action: ReturnType<typeof firmwareFlashEV3>): Generator
12111211
return [new DataView(reply.payload), undefined];
12121212
}
12131213

1214-
const [version, versionError] = yield* sendCommand(0xf6); // get version
1215-
1216-
if (versionError) {
1217-
yield* put(
1218-
alertsShowAlert('alerts', 'unexpectedError', {
1219-
error: ensureError(versionError),
1220-
}),
1221-
);
1222-
yield* put(firmwareDidFailToFlashEV3());
1223-
yield* cleanup();
1224-
return;
1225-
}
1226-
1227-
defined(version);
1228-
1229-
console.debug(
1230-
`EV3 bootloader version: ${version.getUint32(
1231-
0,
1232-
true,
1233-
)}, HW version: ${version.getUint32(4, true)}`,
1234-
);
1235-
12361214
// FIXME: should be called much earlier.
12371215
yield* put(didStart());
12381216

0 commit comments

Comments
 (0)