feat(ci): switch to uv publish for PyPI uploads#13991
Merged
Conversation
Member
Author
|
(My plan here is to make |
alex
reviewed
Dec 13, 2025
869551c to
dd8268e
Compare
alex
reviewed
Feb 10, 2026
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
9941119 to
4797218
Compare
alex
reviewed
Apr 24, 2026
Comment on lines
+50
to
+51
| cache: pip | ||
| cache-dependency-path: ci-constraints-requirements.txt |
Member
There was a problem hiding this comment.
no cache please, for things in the release path we don't want any caching bug or cache contamination risks
Member
Author
There was a problem hiding this comment.
Hmm, I'm actually surprised zizmor didn't flag this. I'll look into that separately too.
|
|
||
| - run: python -m pip install -c ci-constraints-requirements.txt 'uv' | ||
|
|
||
| - uses: dawidd6/action-download-artifact@5c98f0b039f36ef966fdb7dfa9779262785ecb05 # v14 |
Member
There was a problem hiding this comment.
version change which is incidental, I assume
Member
Author
There was a problem hiding this comment.
Yep, just from me merging the wrong side of the conflict. I'll re-bump back to v20.
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
alex
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches
pypi-publish.ymlfromgh-action-pypi-publishtouv publish. The upload itself is still through Trusted Publishing, and attestations are preserved throughastral-sh/attest-action(which can be removed in the medium-term, onceuv publishitself supports attestation generation).Noting a few things from conversation with @reaperhulk:
- This runsuv publishdirectly, since the uv binary is configured on the$PATHimplicitly viaastral-sh/attest-action. This is arguably undesirable, since cryptography otherwise pins uv via a requirements file.- Separately, this currently runs the latest uv release at all times, sinceastral-sh/attest-actiondoesn't attempt to pin it (besides a lower bound for compatibility). This is "ok" from Astral's own trust domain, but it might not be what you want in your release pathway for stability/reproducibility purposes.Both of the above have been addressed: this now uses only the version of
uvthat the rest of the CI is constrained against.TL;DR: This all works, but the current approach may not be what you want in terms of version pinning.