Commit e4f43ff
perf: Cast entire Date32 array to Date64 on 1st failure (apache#21948)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes apache#123` indicates that this PR will close issue apache#123.
-->
- Closes apache#17152
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
- [x] 1. `Vec<Option<String>>` extra allocations
- Resolved in apache#20635 by using
`StringBuilder`
- [ ] 2. Per-row cast on fallback
- Will be resolved in this PR
```rust
// When `Date32` formatting fails (due to time specifiers),
// the code called cast individually for each row instead of converting the entire array
let date64_value = cast(&data_array.slice(idx, 1), &Date64)?;
```
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
Cast the entire Date32 array to Date64 once on first failure, instead of
per-row
```rust
cast(data_array.as_ref(), &Date64
```
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
4. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
Yes
- Add 2 benchmarks:
- `Date32 + datetime` patterns (all rows trigger the fallback)
- `Date32 + mixed patterns` (roughly half do)
```bash
┌─────────────────────────────────────┬───────────────────┬───────────┐
│ Benchmark │ Format │ Change │
├─────────────────────────────────────┼───────────────────┼───────────┤
│ array_date_only_patterns_1000 │ array, date-only │ No change │
├─────────────────────────────────────┼───────────────────┼───────────┤
│ array_datetime_patterns_1000 │ array, datetime │ -3.21% │
├─────────────────────────────────────┼───────────────────┼───────────┤
│ array_mixed_patterns_1000 │ array, mixed │ +1.41% │
├─────────────────────────────────────┼───────────────────┼───────────┤
│ scalar_date_only_pattern_1000 │ scalar, date-only │ No change │
├─────────────────────────────────────┼───────────────────┼───────────┤
│ scalar_datetime_pattern_1000 │ scalar, datetime │ No change │
├─────────────────────────────────────┼───────────────────┼───────────┤
│ array_date32_datetime_patterns_1000 │ array, datetime │ -20.24% │
├─────────────────────────────────────┼───────────────────┼───────────┤
│ array_date32_mixed_patterns_1000 │ array, mixed │ -15.74% │
└─────────────────────────────────────┴───────────────────┴───────────┘
```
<details>
<summary>Detail</summary>
```bash
cargo bench --bench to_char
Compiling datafusion-functions v53.1.0 (/Users/qmac/Documents/GitHub/datafusion/datafusion/functions)
Finished `bench` profile [optimized] target(s) in 1m 10s
Running benches/to_char.rs (target/release/deps/to_char-d2acea4b7a3e2fba)
Gnuplot not found, using plotters backend
Benchmarking to_char_array_date_only_patterns_1000: Warming up for 3.00Benchmarking to_char_array_date_only_patterns_1000: Collecting 100 sampto_char_array_date_only_patterns_1000
time: [104.01 µs 104.37 µs 104.74 µs]
change: [−0.5692% +0.3244% +1.0788%] (p = 0.47 > 0.05)
No change in performance detected.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) low mild
2 (2.00%) high mild
Benchmarking to_char_array_datetime_patterns_1000: Warming up for 3.000Benchmarking to_char_array_datetime_patterns_1000: Collecting 100 samplto_char_array_datetime_patterns_1000
time: [165.96 µs 166.43 µs 166.94 µs]
change: [−4.1660% −3.2055% −2.3626%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) low mild
3 (3.00%) high mild
1 (1.00%) high severe
Benchmarking to_char_array_mixed_patterns_1000: Collecting 100 samples to_char_array_mixed_patterns_1000
time: [139.58 µs 140.02 µs 140.49 µs]
change: [+1.0116% +1.4122% +1.8178%] (p = 0.00 < 0.05)
Performance has regressed.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) low mild
2 (2.00%) high mild
Benchmarking to_char_scalar_date_only_pattern_1000: Warming up for 3.00Benchmarking to_char_scalar_date_only_pattern_1000: Collecting 100 sampto_char_scalar_date_only_pattern_1000
time: [60.073 µs 63.184 µs 66.309 µs]
change: [−4.0228% +0.6839% +6.1581%] (p = 0.79 > 0.05)
No change in performance detected.
Benchmarking to_char_scalar_datetime_pattern_1000: Warming up for 3.000Benchmarking to_char_scalar_datetime_pattern_1000: Collecting 100 samplto_char_scalar_datetime_pattern_1000
time: [117.65 µs 124.76 µs 131.84 µs]
change: [−3.3009% +2.6889% +8.6148%] (p = 0.37 > 0.05)
No change in performance detected.
Found 30 outliers among 100 measurements (30.00%)
16 (16.00%) low mild
14 (14.00%) high mild
Benchmarking to_char_array_date32_datetime_patterns_1000: Warming up foBenchmarking to_char_array_date32_datetime_patterns_1000: Collecting 10to_char_array_date32_datetime_patterns_1000
time: [289.67 µs 290.77 µs 291.88 µs]
change: [−20.661% −20.240% −19.863%] (p = 0.00 < 0.05)
Performance has improved.
Benchmarking to_char_array_date32_mixed_patterns_1000: Warming up for 3Benchmarking to_char_array_date32_mixed_patterns_1000: Collecting 100 sto_char_array_date32_mixed_patterns_1000
time: [194.47 µs 195.28 µs 196.11 µs]
change: [−16.230% −15.738% −15.285%] (p = 0.00 < 0.05)
Performance has improved.
```
</details>
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
No
---------
Co-authored-by: Kumar Ujjawal <ujjawalpathak6@gmail.com>1 parent 739e147 commit e4f43ff
1 file changed
Lines changed: 30 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
248 | 248 | | |
249 | 249 | | |
250 | 250 | | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
251 | 256 | | |
252 | 257 | | |
253 | 258 | | |
| |||
266 | 271 | | |
267 | 272 | | |
268 | 273 | | |
269 | | - | |
270 | 274 | | |
271 | 275 | | |
272 | | - | |
273 | | - | |
274 | | - | |
275 | | - | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
276 | 286 | | |
277 | 287 | | |
278 | 288 | | |
| |||
307 | 317 | | |
308 | 318 | | |
309 | 319 | | |
310 | | - | |
311 | | - | |
312 | | - | |
313 | | - | |
314 | | - | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
315 | 335 | | |
316 | 336 | | |
317 | 337 | | |
| |||
0 commit comments