Fix IndexError in Digest auth header parser on empty values#1023
Open
mbeijen wants to merge 1 commit into
Open
Fix IndexError in Digest auth header parser on empty values#1023mbeijen wants to merge 1 commit into
mbeijen wants to merge 1 commit into
Conversation
Drop the `unquote` helper in favour of `str.strip('"')`, matching the
style already used for header parsing. Port of encode/httpx#3771
(Jeroen van Zundert, with akx's improvement).
Co-Authored-By: Jeroen van Zundert <mail@jeroenvanzundert.nl>
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Digest auth challenge parser called a private
unquotehelper that index-errored on empty values, so aWWW-Authenticateheader likeDigest realm=, qop="auth", …would crash instead of being parsed as an empty realm. Switching tovalue.strip('"')(matching the pattern already used elsewhere for header parsing) fixes that, and also handles unbalanced or repeated quotes — see the rationale in encode/httpx#3771.Port of encode/httpx#3771 by @JeroenVanZundert, with @akx's
.strip('"')improvement applied.Note: this change was prepared with AI assistance (Claude Code).