Skip to content

Bump click lower bound to >=8.4 and drop upper bound#1040

Merged
Kludex merged 3 commits into
pydantic:mainfrom
drusc0:worktree-bright-nibbling-horizon
Jul 14, 2026
Merged

Bump click lower bound to >=8.4 and drop upper bound#1040
Kludex merged 3 commits into
pydantic:mainfrom
drusc0:worktree-bright-nibbling-horizon

Conversation

@drusc0

@drusc0 drusc0 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Bumps the click lower bound in the cli extra from ==8.* to >=8.4,<9, resolving to 8.4.1 in the lockfile (up from 8.2.1).

Refs #886

Notes on #886

The Error: No such option: -s in #886 is expected behavior — -s is not defined in the httpx2 CLI and no click version adds it automatically. The bump brings in error message formatting improvements and tuple-type option parsing fixes (type=(str, str) used by --params, --headers, --data, etc.).

Test plan

  • scripts/lint passes
  • scripts/test passes (full suite + 100% coverage)

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@codspeed-hq

codspeed-hq Bot commented Jun 19, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 15 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing drusc0:worktree-bright-nibbling-horizon (6ef78ab) with main (0dd0ee0)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Kludex Kludex changed the title chore: bump click lower bound to >=8.4,<9 Bump click lower bound to >=8.4 and drop upper bound Jul 14, 2026
@Kludex
Kludex merged commit 2cb02fe into pydantic:main Jul 14, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants