Raise opentelemetry-sdk ceiling to <1.44.0 (allow 1.43) (#2042)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Alex Hall <alex.mojaki@gmail.com>

Author: 3 people

logfire/_internal/config.py

@@ -1435,6 +1435,8 @@ def check_tokens():
                     resource=resource,
                     views=self.metrics.views,
                 )
+                # For easy testing
+                meter_provider._logfire_metric_readers = metric_readers  # type: ignore
                 for reader in metric_readers:
                     with suppress(Exception):
                         # Prevent metric readers from recording metrics about themselves which just adds noise.

logfire/_internal/exporters/test.py

@@ -150,7 +150,12 @@ def process_attribute(
         assert value == os.getpid()
         return 1234
     if name == 'service.instance.id':
-        if re.match(r'^[0-9a-f]{32}$', value):
+        # OpenTelemetry <=1.42 set this to `uuid4().hex` (32 hex chars); 1.43+ uses the
+        # dashed UUID form. Normalise either representation to a fixed value so snapshots
+        # stay deterministic across OTel versions.
+        if re.match(r'^[0-9a-f]{32}$', value) or re.match(
+            r'^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$', value
+        ):
             return '0' * 32
     if parse_json_attributes and isinstance(value, str) and (value.startswith('{') or value.startswith('[')):
         try:

pyproject.toml

@@ -46,8 +46,8 @@ classifiers = [
     "Framework :: OpenTelemetry :: Instrumentations",
 ]
 dependencies = [
-    "opentelemetry-sdk >= 1.39.0, < 1.43.0",
-    "opentelemetry-exporter-otlp-proto-http >= 1.39.0, < 1.43.0",
+    "opentelemetry-sdk >= 1.39.0, < 1.44.0",
+    "opentelemetry-exporter-otlp-proto-http >= 1.39.0, < 1.44.0",
     "opentelemetry-instrumentation >= 0.41b0",
     "rich >= 13.4.2",
     "protobuf >= 4.23.4",

tests/exporters/test_otlp_session.py

@@ -11,6 +11,7 @@
 import pytest
 import requests
 import requests.exceptions
+from dirty_equals import IsStr
 from inline_snapshot import snapshot
 from opentelemetry.sdk.trace.export import SpanExportResult
 from requests.models import PreparedRequest, Response as Response
@@ -45,7 +46,9 @@ def test_max_body_size_bytes() -> None:
     exporter.max_body_size = 10
     with pytest.raises(BodyTooLargeError) as e:
         exporter.export(TEST_SPANS)
-    assert str(e.value) == snapshot('Request body is too large (897045 bytes), must be less than 10 bytes.')
+    # The exact serialized size depends on the OpenTelemetry version, so match the message shape
+    # rather than a hardcoded byte count.
+    assert str(e.value) == IsStr(regex=r'Request body is too large \(\d+ bytes\), must be less than 10 bytes\.')
 
 
 def test_connection_error_retries(monkeypatch: pytest.MonkeyPatch, caplog: pytest.LogCaptureFixture) -> None:

tests/test_configure.py

@@ -2299,8 +2299,15 @@ def get_span_processors() -> Iterable[SpanProcessor]:
     return result[1:]
 
 
-def get_metric_readers() -> Iterable[SpanProcessor]:
-    return get_meter_provider().provider._sdk_config.metric_readers  # type: ignore
+def get_metric_readers() -> Iterable[object]:
+    provider = get_meter_provider().provider  # type: ignore
+    result = provider._logfire_metric_readers  # type: ignore
+    try:
+        # This only works on older OTel versions and is just a sanity check now.
+        assert result == provider._sdk_config.metric_readers  # type: ignore
+    except AttributeError:
+        pass
+    return result  # type: ignore
 
 
 def get_log_record_processors() -> Iterable[LogRecordProcessor]: