Skip to content

GoogleSecretManagerSettingsSource: skip the list secrets step when case_sensitive=True #861

@ecerulm

Description

@ecerulm

Currently GoogleSecretManagerSettingsSource will unconditionally list_secrets() which requires secretmanager.secrets.list.

As far as I understand the only purpose of this list_secrets is to support the case ignore matching of the secret names.

In principle, with the current code both IAM roles Secret Manager Secret Accessor
(roles/secretmanager.secretAccessor)
+ Secret Manager Viewer
(roles/secretmanager.viewer)
even when case_sensitive=True

If the list_secrets step is skipped then it will work with just Secret Manager Secret Accessor
(roles/secretmanager.secretAccessor)
.

On a related note maybe it would be nice to document that both Secret Manager Secret Accessor and Secret Manager Viewer are currently required for this to work.

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions