mypy

Author: shoyer

xarray/backends/api.py

@@ -2001,7 +2001,7 @@ def to_netcdf(
 
     if isinstance(path_or_file, str) or path_or_file is None:
         if engine is None:
-            engine = _get_default_engine(path_or_file, format)
+            engine = _get_default_engine(path_or_file, format=format)
         path_or_file = _normalize_path(path_or_file)
     # writing to a file-like object
     elif engine is None:
@@ -2076,7 +2076,7 @@ def to_netcdf(
 
     if path_or_file is None:
         assert isinstance(target, BytesIOProxy)  # created in this function
-        return target.getvalue_or_getbuffer()
+        return target.getbuffer()
 
     if not compute:
         return delayed_close_after_writes(writes, store)

xarray/backends/netCDF4_.py

@@ -695,11 +695,11 @@ def guess_can_open(self, filename_or_obj: T_PathFileOrDataStore) -> bool:
         if isinstance(filename_or_obj, str) and is_remote_uri(filename_or_obj):
             return True
 
-        if isinstance(filename_or_obj, bytes | memoryview):
-            magic_number = bytes(filename_or_obj[:8])
-        else:
-            magic_number = try_read_magic_number_from_path(filename_or_obj)
-
+        magic_number = (
+            bytes(filename_or_obj[:8])
+            if isinstance(filename_or_obj, bytes | memoryview)
+            else try_read_magic_number_from_path(filename_or_obj)
+        )
         if magic_number is not None:
             # netcdf 3 or HDF5
             return magic_number.startswith((b"CDF", b"\211HDF\r\n\032\n"))

xarray/core/datatree_io.py

@@ -52,7 +52,7 @@ def _datatree_to_netcdf(
         )
 
     if engine is None:
-        engine = get_default_engine_netcdf(format="NETCDF4")
+        engine = get_default_engine_netcdf(format="NETCDF4")  # type: ignore[assignment]
 
     if group is not None:
         raise NotImplementedError(
@@ -89,7 +89,7 @@ def _datatree_to_netcdf(
 
     root_store = get_writable_netcdf_store(
         target,
-        engine,
+        engine,  # type: ignore[arg-type]
         mode=mode,
         format=format,
         autoclose=autoclose,
@@ -125,7 +125,7 @@ def _datatree_to_netcdf(
         writes = writer.sync(compute=compute)
 
     finally:
-        if compute:  # type: ignore[redundant-expr]
+        if compute:
             root_store.close()
 
     if filepath is None:

xarray/tests/test_backends_api.py

@@ -7,7 +7,7 @@
 import pytest
 
 import xarray as xr
-from xarray.backends.api import _get_default_engine, _get_default_engine_netcdf
+from xarray.backends.api import _get_default_engine, get_default_engine_netcdf
 from xarray.tests import (
     assert_identical,
     assert_no_warnings,
@@ -39,7 +39,7 @@ def test_default_engine_h5netcdf(monkeypatch):
     monkeypatch.delitem(sys.modules, "scipy", raising=False)
     monkeypatch.setattr(sys, "meta_path", [])
 
-    assert _get_default_engine_netcdf() == "h5netcdf"
+    assert get_default_engine_netcdf(format=None) == "h5netcdf"
 
 
 def test_custom_engine() -> None:

xarray/tests/test_backends_datatree.py

@@ -736,7 +736,7 @@ def assert_expected_zarr_files_exist(
         in_progress_dt = load_datatree(str(storepath), engine="zarr")
         assert not in_progress_dt.equals(original_dt)
 
-        result.compute()
+        result.compute()  # type: ignore[union-attr]
         written_dt = load_datatree(str(storepath), engine="zarr")
         assert_identical(written_dt, original_dt)