Skip to content

Fix merge defaults for Dataset._setitem_ and Dataset.update#10651

Open
dhruvak001 wants to merge 1 commit into
pydata:mainfrom
dhruvak001:issue#10585
Open

Fix merge defaults for Dataset._setitem_ and Dataset.update#10651
dhruvak001 wants to merge 1 commit into
pydata:mainfrom
dhruvak001:issue#10585

Conversation

@dhruvak001
Copy link
Copy Markdown
Contributor

Updates dataset_update_method to use join="left" and compat="override" instead of the expensive defaults join="outer" and compat="broadcast_equals".

@shoyer
Copy link
Copy Markdown
Member

shoyer commented Aug 21, 2025

The fact that we no tests need to be changed with these new defaults is a little suspicious. It suggests that either we lack test coverage or these defaults aren't actually used in the update() codepath, which uses the internal priority_arg argument.

As discussed in #10585 (comment), a better clean-up might be to get rid of priority_arg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better "merge" defaults for Dataset.__setitem__ and Dataset.update

2 participants