Fix h5netcdf backend module detection and ros3 tests#11274
Merged
kmuehlbauer merged 10 commits intopydata:mainfrom Apr 8, 2026
Merged
Fix h5netcdf backend module detection and ros3 tests#11274kmuehlbauer merged 10 commits intopydata:mainfrom
kmuehlbauer merged 10 commits intopydata:mainfrom
Conversation
kmuehlbauer
commented
Apr 1, 2026
3 tasks
maxrjones
pushed a commit
to maxrjones/xarray
that referenced
this pull request
Apr 8, 2026
* use var._root._h5py to get h5py module in h5netcdf backend instead of importing it * fix ros3 tests to use DANDI endpoint and include hdf5 version switch * fix phony_dims for ros3 test * fix import check for ros3 availability * try using property to get around import issue * add whats-new.rst entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with upstream h5netcdf:
This fixes breaking ROS3 tests, when using HDF2 >= 2. We currently do not check nightly h5netcdf, so this was missed here. It was discovered in h5netcdf tests, which is testing xarray nightly.
This enables installation of xarray without h5py in the environment, as now the used module is discovered from h5netcdf backend variable.
whats-new.rst