Fix min_count support for multi-dimensional reductions#11307
Open
badcount wants to merge 1 commit intopydata:mainfrom
Open
Fix min_count support for multi-dimensional reductions#11307badcount wants to merge 1 commit intopydata:mainfrom
badcount wants to merge 1 commit intopydata:mainfrom
Conversation
- Remove restriction that prevented min_count with tuple/list axes - Use np.take(mask.shape, axis).prod() for computing total elements across multiple axes - Add _is_nat_dtype helper to fix NaT dtype comparison bug - Update docstrings for clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the restriction that prevented using min_count with tuple/list axes in reduction operations like sum and prod. It also fixes a pre-existing bug in NAT_TYPES comparison and adds proper handling for multiple axes.