SQLAlchemyTrackingRecorder implementationn#27
Merged
johnbywater merged 7 commits intoFeb 6, 2026
Conversation
tests/test_recorders.py:90: error: Signature of "test_concurrent_no_conflicts" incompatible with supertype "ApplicationRecorderTestCase
…dency error
/eventsourcing/tests/postgres_utils.py", line 13, in <module>
from examples.dcb_enrolment_with_basic_objects.postgres_ts import (
ModuleNotFoundError: No module named 'examples'
Contributor
|
Thanks @mobuild-io great work! |
Contributor
|
I just published your changes as version 0.13: https://pypi.org/project/eventsourcing-sqlalchemy/0.13/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first pull request. In this pull request, I first updated the eventsourcing library to the latest version and did the appropriate fix.
Then I followed the template from the eventsourcing recorder by extracting a root SQLAlchemyRecorder and updated the recorder classes accordingly. Then I implemented the SQLAlchemyTrackingRecorder along with its tests.
I will also have the SQLAlchemySubscription in a future pull request.