Add type hints to cli.__init__.py#193
Closed
hnet158158 wants to merge 2 commits into
Closed
Conversation
Signed-off-by: hnet158158 <hnet158158@gmail.com>
Contributor
|
Thx for your work! Please, resolve merge conflict, and I will merge this PR |
ApusBerliozi
self-requested a review
June 30, 2026 05:59
…tream), add GRID from upstream
Author
|
Merge conflict resolved. The AUTH section was dropped (since it was removed upstream) while keeping RUN + type hints and the new GRID section from upstream. |
Contributor
|
@hnet158158, thx! We don't need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds type hints (annotations) for all variables and the
main()function signature incli.__init__.py, improving code clarity and enabling stricter mypy checks.Changes:
from __future__ import annotationsfor forward-compatibilityparser,subparsers, all subcommand parsers (p_pull,p_list,p_dash,p_run,p_auth,p_grid,auth_subparsers,p_login,p_status,p_logout) withargparse.ArgumentParserargswithargparse.Namespaceinmain()-> Noneand parameter typeargv: list[str] | None = Nonetomain()Closes #190