Fix RandomNodeSplit HeteroData bug for unlabeled nodes (#10632)#10659
Open
ninjitsuytber wants to merge 4 commits into
Open
Fix RandomNodeSplit HeteroData bug for unlabeled nodes (#10632)#10659ninjitsuytber wants to merge 4 commits into
ninjitsuytber wants to merge 4 commits into
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ninjitsuytber
requested review from
akihironitta,
rusty1s and
wsad1
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
RandomNodeSplitfailed onHeteroDataobjects when some node types lacked a label attribute (y), even if the split mode (train_rest) didn't require them.The fix ensures that node stores without labels are only skipped for split modes that actually require labels (
test_restorrandom).Updated unit tests to cover HeteroData scenarios with unlabeled node types.
Fixes #10632.