fix(perf): Don't use data-dependent op when batch_size and max_num_nodes are provided to to_dense_batch#10660
Open
akihironitta wants to merge 2 commits into
Open
fix(perf): Don't use data-dependent op when batch_size and max_num_nodes are provided to to_dense_batch#10660akihironitta wants to merge 2 commits into
batch_size and max_num_nodes are provided to to_dense_batch#10660akihironitta wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two issues in
to_dense_batch:to_dense_batchtriggers a D2H sync even whenbatch_sizeandmax_num_nodesare provided because ofnum_nodes.max() > max_num_nodesto decide whether to run boolean masking onxandidx.capture_dynamic_output_shape_ops=True, but in our case, this new implementation guarantees that the shape is static for a givenbatch_sizeandmax_num_nodesat compile time, so there's no need to continue to use the op.Benchmark
torch==2.12.0.dev20260322+cu130, g6.4xlarge (L4)Before (3a4b881)
After (this PR)