Skip to content

Fix OnDiskDataset access after index_select()#10674

Open
Karl-XZ wants to merge 2 commits into
pyg-team:masterfrom
Karl-XZ:codex/pyg-ondiskdataset-index-select
Open

Fix OnDiskDataset access after index_select()#10674
Karl-XZ wants to merge 2 commits into
pyg-team:masterfrom
Karl-XZ:codex/pyg-ondiskdataset-index-select

Conversation

@Karl-XZ
Copy link
Copy Markdown

@Karl-XZ Karl-XZ commented Apr 24, 2026

Fix OnDiskDataset.get() and related subset access after index_select().

Subsets created from OnDiskDataset.index_select() returned inconsistent
results between subset[idx] and subset.get(idx), because get() did not
resolve indices through self.indices().

This PR aligns get(), multi_get(), and __getitem__() for subset access
and adds a regression test.

Testing

python -m pytest test/data/test_on_disk_dataset.py -q

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant