Skip to content

Commit 0c976ec

Browse files
committed
Fix three silent assertions missing @test
Lines 154, 215, 284 had bare equality expressions that never ran as tests. Also update the summary comment to reference issues #14 and #15. Closes #16
1 parent 5b9a101 commit 0c976ec

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

test/runtests.jl

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ end
151151
@test (A)₋ == A[:-] == odd(A) == A.odd()
152152

153153
for r dimV
154-
A[r] == A.grade(r) == A.get_grade(r)
154+
@test A[r] == A.grade(r) == A.get_grade(r)
155155
end
156156

157157
# The following tests verified many identities in Linear Algebra
@@ -176,10 +176,11 @@ end
176176
# Summary
177177
#
178178
# - The formulas after XXX are work-in-progress
179-
# - The following formulas are skip for now
180-
# - A.4.27
179+
# - The following formulas are skipped for now
180+
# - A.4.27 (not yet investigated)
181181
# - The following formulas are broken for now
182-
# - A.4.{33, 35}
182+
# - A.4.33 (see issue #14)
183+
# - A.4.35 (see issue #15)
183184

184185
@test v * v == (v * v).scalar()
185186
@test v * B == v B + v B == v B + v B
@@ -212,7 +213,7 @@ end
212213
@test Ar * v == Ar v + Ar v
213214

214215
Br = B[r]
215-
Ar Br == Ar Br == (Ar * Br).scalar()
216+
@test Ar Br == Ar Br == (Ar * Br).scalar()
216217

217218
if r > 0
218219
a = V.mv("a", "vector")
@@ -281,7 +282,7 @@ end
281282
for t dimV
282283
Ct = C[t]
283284

284-
Ar (Bs Ct) == (Ar * Bs * Ct)[r + s + t]
285+
@test Ar (Bs Ct) == (Ar * Bs * Ct)[r + s + t]
285286
end
286287
end
287288
end

0 commit comments

Comments
 (0)