Allowing facts.server.Command non-zero exit values

[rktjmp]

When I run a facts.server.Command that may return a non-zero exit status, how can I treat this as expected?

Eg, podman secret exists my_secret will exit-0 if the secret exists, or exit-1 if it doesn't. I want to check if the secret exists and delete it if so, before creating it with a new value.

In the case where the secret does not exist, doing something like

host.get_fact(facts.server.Command, "podman secret exists my_secret")

Raises a hard error and stops the deployment.

Doing

try:
    host.get_fact(facts.server.Command, "podman secret exists my_secret")
except:
    pass

Lets the deployment continue, but:

• logs a red [host] Error: could not load fact... message
• prevents the operation from actually continuing and applying anything.

I can get around this sort of by doing

    yield StringCommand("podman secret exists {} && podman secret rm {} || exit 0".format(id, id))
    yield StringCommand("echo -n '{}' | podman secret create {} -".format(value, id))

But it feels a bit ugly... I'm not much of a python programmer, perhaps im just using the try/except wrong? Ideally I could just write

try:
    host.get_fact(facts.server.Command, "podman secret exists {}".format(id))
    # no exception, assume podman cmd exists but secret did not exist
    # perhaps except CommandError(exit=1) vs CommandError(not_found) or whatever?
    yield StringCommand("podman secret rm {}".format(id))
except:
    pass
yield StringCommand(create...)

[rktjmp]

You can add _success_exit_codes=[0,1] which will allow the command to succeed, but there doesn't seem to be a way to get the exit code of the command.

Seems the best option is to handle the exit code in the command itself, eg

    x = host.get_fact(
        server.Command,
        f"podman secret exists {key} && echo {key} || true"
    )
    if x != None:
        print(f"{key} does exist")
    else:
        print(f"{key} did not exist")

Note that podman secret exists outputs nothing, ever, behaviour may be different if a command outputs nothing to stdout but does write to stderr where checking for None may not work.