Skip to content

refactor: asyncio, ssh-cli, AsyncSSH, AsyncContext#1482

Open
JakkuSakura wants to merge 6 commits intopyinfra-dev:4.xfrom
JakkuSakura:async
Open

refactor: asyncio, ssh-cli, AsyncSSH, AsyncContext#1482
JakkuSakura wants to merge 6 commits intopyinfra-dev:4.xfrom
JakkuSakura:async

Conversation

@JakkuSakura
Copy link
Copy Markdown
Contributor

@JakkuSakura JakkuSakura commented Oct 10, 2025

  • Pull request is based on the default branch (3.x at this time)
  • A 4.x branch should be created
  • Pull request includes tests for any new/updated operations/facts
  • Pull request includes documentation for any new/updated operations/facts
  • Tests pass (see scripts/dev-test.sh)
  • Type checking & code style passes (see scripts/dev-lint.sh)
  • Feature parity of old version
  • Verified code compatibility with 3.x
  • AsyncContext fully implemented

closes #1478

closes #1474

Copy link
Copy Markdown
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! This is incredible work, @JakkuSakura. I think moving to asyncio is definitely the way forward - I actually think we should make pyinfra's API async only and remove the complexity of having the two context types.

I still need to read through the PR in full, but generally this looks amazing, nice that the API changes aren't actually too crazy. I'd like to figure out how we can make the API accessible with minimal boilerplate, I think this is possible if we go all async.

Going to reach out (email) to figure out how we can best land this (and 4.x).

@JakkuSakura
Copy link
Copy Markdown
Contributor Author

Glad to hear this. I'm going to use this branch in my own project to see if it causes any issues

@Fizzadar Fizzadar added this to the v4 milestone Oct 21, 2025
@JakkuSakura JakkuSakura changed the base branch from 3.x to 4.x December 2, 2025 13:14
@JakkuSakura JakkuSakura marked this pull request as ready for review December 2, 2025 13:14
@JakkuSakura
Copy link
Copy Markdown
Contributor Author

I've been using it for a while without issues. Any chance of merging it?

@JakkuSakura JakkuSakura changed the title refactor: use asyncio & AsyncSSH, introduce AsyncContext refactor: asyncio, ssh-cli, AsyncSSH, AsyncContext Feb 27, 2026
@Dexmachi
Copy link
Copy Markdown
Contributor

What is the current situation for this PR?

@Fizzadar
Copy link
Copy Markdown
Member

Current state of PR: this is a huge undertaking and breaking change, so this is effectively v4 development right now, with no timeline for release as of yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Asynchronous operation, Asynchronous ssh, sftp file attribute manipulation, scp file transfer Async & immediate-mode API

3 participants