refactor: asyncio, ssh-cli, AsyncSSH, AsyncContext#1482
refactor: asyncio, ssh-cli, AsyncSSH, AsyncContext#1482JakkuSakura wants to merge 6 commits intopyinfra-dev:4.xfrom
Conversation
Fizzadar
left a comment
There was a problem hiding this comment.
Wow! This is incredible work, @JakkuSakura. I think moving to asyncio is definitely the way forward - I actually think we should make pyinfra's API async only and remove the complexity of having the two context types.
I still need to read through the PR in full, but generally this looks amazing, nice that the API changes aren't actually too crazy. I'd like to figure out how we can make the API accessible with minimal boilerplate, I think this is possible if we go all async.
Going to reach out (email) to figure out how we can best land this (and 4.x).
|
Glad to hear this. I'm going to use this branch in my own project to see if it causes any issues |
|
I've been using it for a while without issues. Any chance of merging it? |
|
What is the current situation for this PR? |
|
Current state of PR: this is a huge undertaking and breaking change, so this is effectively v4 development right now, with no timeline for release as of yet. |
Pull request is based on the default branch (3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)closes #1478
closes #1474