selinux.port: fix a bug where the op would not find existing labels if sepolicy command was missing from the host#1654
Merged
Fizzadar merged 2 commits intopyinfra-dev:3.xfrom Apr 20, 2026
Conversation
This way port numbers are ints, as documented. This exposes a bug in selinux.port that looks up port numbers as strings. FAILED tests/test_operations.py::selinux.port::test_selinux_port_add_different - AssertionError: assert ['semanage po..._t -p tcp 22'] == ['semanage po..._t -p tcp 22'] FAILED tests/test_operations.py::selinux.port::test_selinux_port_add_same - AssertionError: assert ['semanage po..._t -p tcp 22'] == [] FAILED tests/test_operations.py::selinux.port::test_selinux_port_remove_existing - AssertionError: assert [] == ['semanage port -d -p tcp 22']
yacoob
changed the title
sepolicy command was missing from the hostsepolicy command was missing from the host
Fizzadar
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is the right direction to converge on, as there's probably code out there that uses pyinfra and expects ints. Or not, given this has flown 4y under the radar :D
I've converted the test fixtures to yaml, as you can't have int keys in json. Once converted, the bug was visible, and those test cases started to fail.
Fixes #1644.
3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)