dnf.packages: make it work with dnf5 and handle multiple installation candidates#1655
Open
yacoob wants to merge 5 commits intopyinfra-dev:3.xfrom
Open
dnf.packages: make it work with dnf5 and handle multiple installation candidates#1655yacoob wants to merge 5 commits intopyinfra-dev:3.xfrom
yacoob wants to merge 5 commits intopyinfra-dev:3.xfrom
Conversation
This way it works on newer Fedora versions. Tested this with `fedora:N` containers for N in [39, 43] :)
…didate pkg ...and one of them is already installed. This test fails right now, due to pyinfra-dev#1643.
Fizzadar
requested changes
Apr 20, 2026
Member
Fizzadar
left a comment
Fizzadar
left a comment
There was a problem hiding this comment.
Thanks for the PR, @yacoob. Looks good but breaks pacman group expansions which expect all packages to be installed for a given group. We could add an expand_match_any=False argument to ensure_packages and explicitly set True for yum/dnf.
Co-authored-by: Nick Mills-Barrett <nick@fizzadar.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1643.
3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)