Skip to content

meta: add PR review skill#1683

Merged
DonDebonair merged 3 commits into
3.xfrom
review-prs-skill
May 3, 2026
Merged

meta: add PR review skill#1683
DonDebonair merged 3 commits into
3.xfrom
review-prs-skill

Conversation

@Fizzadar

Copy link
Copy Markdown
Member

Adds a Claude Code skill for reviewing open PRs, with a sync script that tracks review state and skips unchanged PRs.


Written with assistance from Claude.

@DonDebonair

DonDebonair commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

I tried the skill and it works pretty well! Should give us a good head-start with reviews.

2 things I noticed though:

1. Subagents cannot use bash, so the main agent does all the reviews in serial

This could probably be fixed by adding something like this to the frontmatter:

tools: Read, Grep, Glob, Bash

2. Each PR review gets a verdict, as the skill suggests, but in the summary at the end, some PRs get multiple verdicts

This is the output when I ran it:

  GO (merge-ready) — 20 PRs:
  - #1431 shellcheck CI, #1558 systemd state fix, #1601 brew version parse, #1625 docker custom command, #1642 command injection fix, #1647 requires_command sentinel, #1655 dnf5 compat, #1660 DNF modules,
  #1662 --json flag, #1666 _temp_dir askpass, #1669 EtcHosts/Last/LoadAverage, #1671 UFW module, #1672 AI agent docs, #1675 docker compose/build/login, #1676 group data import leak, #1682 llms.txt, #1683 PR
  review skill, #1684 repo filename field, #1685 BSD rc.d dispatch, #1686 facts docs labels, #1687 download reconcile, #1690 git no-pull when up-to-date, #1691 CI improvements

  NO-GO — 2 PRs:
  - #1301 — draft/incomplete docs, not linked in toctree
  - #1530 — locale.gen entry truncated by sed (strips required charset suffix)

  NEEDS-DISCUSSION — 11 PRs:
  - #1482 — major v4.0 asyncio/AsyncSSH rewrite
  - #1487/#1597 — apt key/sources series (API changes, series dependency)
  - #1556/#1689 — conflicting sudo single-try fixes (pick one)
  - #1557 — Ansible bridge (GPLv3 file, optional dep, belongs in core?)
  - #1594 — removes choco (breaking), adds upgrade facts
  - #1658 — EXECUTION_ONLY flag design questions
  - #1690 — git pull skip (extra network calls)

#1690 for example is listed as both GO and NEEDS-DISCUSSION.

The skill does not explicitly say that it should give this summary at the end, so Claude made that up. We could make the summary explicit and give guidance that the classification should match what's in the reviews.

@Fizzadar

Copy link
Copy Markdown
Member Author

@DonDebonair updated the prompt + frontmatter per above. One thing I noticed it this requires having accept edits enabled or the agents will get stuck writing (eventually the main chat will read their output and write them itself), not sure that's easy to pre-approve permissions for though 🤔

@DonDebonair DonDebonair left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parallelism works now, so that's great. The only issue I found, is that it only processes full batches of 5, waiting until the batch is fully processed before taking on another review.

Making the changes that I suggest, fixes this. I tested it out and it works great that way!

Comment thread .claude/skills/review-prs/SKILL.md Outdated
Comment thread .claude/skills/review-prs/SKILL.md Outdated
Fizzadar and others added 2 commits May 3, 2026 19:50
Co-authored-by: Daan Debie <daan@dv.email>
Co-authored-by: Daan Debie <daan@dv.email>
@DonDebonair DonDebonair merged commit c28b77d into 3.x May 3, 2026
27 checks passed
@DonDebonair DonDebonair deleted the review-prs-skill branch May 3, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants