fix(operations): handle password prompt from sudo-rs (eg. recent Ubuntu)#1734
Merged
Conversation
wowi42
added
new feature
connectors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On systems using
sudo-rs(eg. recent Ubuntu), sudo password prompts take a slightly different format, which breaks the password prompt spotting logic. (this bit Ansible here: ansible/ansible#85837) This PR fixes that by recognizing both password prompt strings.This should PARTIALLY address #1499, at least enough to limp forward even if that version of
sudodoesn't take all the same flags.This is adjacent to #1689 - it's orthogonal, but touches the same code, and whichever lands second will need a rebase.
3.xat this time)scripts/dev-test.sh) (except for pre-existingapt.packages.test_apt_packages_update_cached)scripts/dev-lint.sh)conventional commits format