fix: limit-aware inventory creation#1757
Open
etiennecollin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This draft PR is a proof of concept for #1756.
The current issue is that
--limit <group>still allows host data from non-selected groups to be merged during inventory construction. If the same host exists in multiple groups with overlapping keys, values from later groups overwrite those from the selected group.This implementation explores passing the
limititerable into theInventoryobject so that host data from non-selected groups can be ignored during inventory construction.The goal here is mainly to validate the approach; I do not expect this implementation to be merged as-is, since it was written fairly quickly and may not align with the intended architecture of the project. It may serve as inspiration for a proper implementation.
Testing
The included tests pass with
scripts/dev-test.sh,but I encountered the following error in one of my real deployments, which does not occur on pyinfraThe error also happens on 3.8.0, so it might be my deployment that is flawed.v3.8.0. So there is likely at least one edge case or unintended side effect in the current implementation.Checklist
3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)