fix(facts.git): GitLocalCommit fact failing on nonlocal ref#1881
Open
yagarea wants to merge 3 commits into
Open
fix(facts.git): GitLocalCommit fact failing on nonlocal ref#1881yagarea wants to merge 3 commits into
yagarea wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1880
Its docstring explicitly promises: "returns None when the repository does not exist, the ref is unknown, or the command fails." And the
process()method is written for that — it validates the output against a SHA regex and returns None otherwise.But the shell command doesn't hold up its end. When the directory exists and the ref is unknown,
git rev-parseexits with code 128. The2>/dev/nullhides the error text but does nothing about the exit code, so the whole fact command exits non-zero. pyinfra treats a failed fact command as fatal —Error: could not load fact— kicks the host out, and you getNo hosts remaining!.As per AI policy I disclose that test were created with assistance of LLM. I have read and tested them manually so its human verified.
3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)conventional commits format