Add test for exception handler in _update_waiting_task batched path

Author: Copilot

src/executorlib/_version.py

@@ -1,21 +1,24 @@
-# file generated by setuptools-scm
+# file generated by vcs-versioning
 # don't change, don't track in version control
+from __future__ import annotations
 
-__all__ = ["__version__", "__version_tuple__", "version", "version_tuple"]
-
-TYPE_CHECKING = False
-if TYPE_CHECKING:
-    from typing import Tuple
-    from typing import Union
-
-    VERSION_TUPLE = Tuple[Union[int, str], ...]
-else:
-    VERSION_TUPLE = object
+__all__ = [
+    "__version__",
+    "__version_tuple__",
+    "version",
+    "version_tuple",
+    "__commit_id__",
+    "commit_id",
+]
 
 version: str
 __version__: str
-__version_tuple__: VERSION_TUPLE
-version_tuple: VERSION_TUPLE
+__version_tuple__: tuple[int | str, ...]
+version_tuple: tuple[int | str, ...]
+commit_id: str | None
+__commit_id__: str | None
+
+__version__ = version = '0.1.dev2+g0a12ed789.d20260610'
+__version_tuple__ = version_tuple = (0, 1, 'dev2', 'g0a12ed789.d20260610')
 
-__version__ = version = "0.0.1"
-__version_tuple__ = version_tuple = (0, 0, 1)
+__commit_id__ = commit_id = None

tests/unit/executor/test_single_dependencies.py

@@ -3,10 +3,14 @@
 from time import sleep, time
 from queue import Queue
 from threading import Thread
+from unittest.mock import MagicMock
 
 from executorlib import SingleNodeExecutor
 from executorlib.executor.single import create_single_node_executor
-from executorlib.task_scheduler.interactive.dependency import _execute_tasks_with_dependencies
+from executorlib.task_scheduler.interactive.dependency import (
+    _execute_tasks_with_dependencies,
+    _update_waiting_task,
+)
 from executorlib.standalone.serialize import cloudpickle_register
 from executorlib.standalone.interactive.spawner import MpiExecSpawner
 
@@ -300,6 +304,43 @@ def test_future_input_dict(self):
             )
             self.assertEqual(fs.result()["a"], 4)
 
+    def test_update_waiting_task_batched_exception(self):
+        """_update_waiting_task catches exceptions from batched_futures and sets them on the batch future."""
+        executor_queue = Queue()
+        batch_future = Future()
+
+        # A mock skip_lst future: done(), exception() returns None (passes get_exception_lst),
+        # but result() raises -- triggering the except block in _update_waiting_task.
+        mock_skip_future = MagicMock()
+        mock_skip_future.done.return_value = True
+        mock_skip_future.exception.return_value = None
+        mock_skip_future.result.side_effect = RuntimeError("unexpected skip error")
+
+        task_dict = {
+            "fn": "batched",
+            "args": (),
+            "kwargs": {
+                "lst": [],
+                "n": 3,
+                "skip_lst": [mock_skip_future],
+            },
+            "future": batch_future,
+            "future_lst": [mock_skip_future],
+            "resource_dict": {},
+        }
+
+        result_lst = _update_waiting_task(
+            wait_lst=[task_dict],
+            executor_queue=executor_queue,
+            refresh_rate=0.0,
+        )
+
+        # The batch future must have the exception propagated (not crashed the scheduler)
+        self.assertTrue(batch_future.done())
+        self.assertIsInstance(batch_future.exception(), RuntimeError)
+        # The failed task is consumed (not re-queued in the wait list)
+        self.assertEqual(len(result_lst), 0)
+
 
 class TestExecutorErrors(unittest.TestCase):
     def test_block_allocation_false_one_worker(self):