Skip to content

Commit a1cd6ce

Browse files
committed
fixes
1 parent d960407 commit a1cd6ce

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

src/executorlib/standalone/batched.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def batched_futures(
3131
done_lst.append(v.result())
3232
if len(done_lst) == n_expected:
3333
return done_lst
34-
if len(failed_lst) == len(lst) and len(failed_lst) > 0:
34+
if len(failed_lst) == len(lst) - len(skip_set) and len(failed_lst) > 0:
3535
return failed_lst[0] # raise the exception only after all futures have failed
3636
else:
3737
return []

tests/unit/standalone/test_batched.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ def test_batched_futures(self):
4949
batched_lst[1].set_result([5, 7, 8])
5050
self.assertEqual(batched_futures(lst=lst, n=3, nested_skip_lst=set()), [1, 2, 4])
5151
self.assertEqual(batched_futures(lst=lst, nested_skip_lst=batched_lst[:1], n=3), [5, 7, 8])
52-
self.assertEqual(batched_futures(lst=lst, nested_skip_lst=batched_lst, n=3), ValueError("Error for 0"))
52+
with self.assertRaises(ValueError):
53+
raise batched_futures(lst=lst, nested_skip_lst=batched_lst, n=3)
5354

5455
def test_batched_futures_not_finished(self):
5556
lst = []

0 commit comments

Comments
 (0)