Skip to content

SlurmClusterExecutor - resubmission of crashed jobs #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-janssen merged 12 commits into from
Jul 3, 2025
Merged

SlurmClusterExecutor - resubmission of crashed jobs #699

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0b33956
Fix SlurmClusterExecutor bug
jan-janssen Jul 2, 2025
504b08b
Format black
pyiron-runner Jul 2, 2025
2af3c61
SlurmClusterExecutor - resubmission of crashed jobs
jan-janssen Jul 2, 2025
e85953e
remove file rather than try and except
jan-janssen Jul 2, 2025
39d53fc
add test
jan-janssen Jul 2, 2025
7400581
extend tests
jan-janssen Jul 2, 2025
48a0d80
Merge remote-tracking branch 'origin/queue_bug' into queue_crash
jan-janssen Jul 2, 2025
17fadfa
fixes
jan-janssen Jul 2, 2025
8a7b993
fix file write
jan-janssen Jul 2, 2025
5c04931
fix import
jan-janssen Jul 2, 2025
21e5a4f
input files
jan-janssen Jul 2, 2025
f7e1bcd
Merge branch 'main' into queue_crash
jan-janssen Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions executorlib/task_scheduler/file/shared.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ def execute_tasks_h5(
cache_directory=cache_directory
):
file_name = os.path.join(cache_directory, task_key + "_i.h5")
if os.path.exists(file_name):
os.remove(file_name)
dump(file_name=file_name, data_dict=data_dict)
if not disable_dependencies:
task_dependent_lst = [
Expand Down
44 changes: 44 additions & 0 deletions tests/test_fluxclusterexecutor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,51 @@ def test_executor(self):
fs1 = exe.submit(mpi_funct, 1)
self.assertFalse(fs1.done())
self.assertEqual(fs1.result(), [(1, 2, 0), (1, 2, 1)])
self.assertEqual(len(os.listdir("executorlib_cache")), 4)
self.assertTrue(fs1.done())

def test_executor_existing_files(self):
with FluxClusterExecutor(
resource_dict={"cores": 2, "cwd": "executorlib_cache"},
block_allocation=False,
cache_directory="executorlib_cache",
) as exe:
cloudpickle_register(ind=1)
fs1 = exe.submit(mpi_funct, 1)
self.assertFalse(fs1.done())
self.assertEqual(fs1.result(), [(1, 2, 0), (1, 2, 1)])
self.assertTrue(fs1.done())
self.assertEqual(len(os.listdir("executorlib_cache")), 4)

with FluxClusterExecutor(
resource_dict={"cores": 2, "cwd": "executorlib_cache"},
block_allocation=False,
cache_directory="executorlib_cache",
) as exe:
cloudpickle_register(ind=1)
fs1 = exe.submit(mpi_funct, 1)
self.assertFalse(fs1.done())
self.assertEqual(fs1.result(), [(1, 2, 0), (1, 2, 1)])
self.assertTrue(fs1.done())
self.assertEqual(len(os.listdir("executorlib_cache")), 4)
for file_name in os.listdir("executorlib_cache"):
file_path = os.path.join("executorlib_cache", file_name )
os.remove(file_path)
if ".h5" in file_path:
with open(file_path, "w") as f:
f.write("test")

with FluxClusterExecutor(
resource_dict={"cores": 2, "cwd": "executorlib_cache"},
block_allocation=False,
cache_directory="executorlib_cache",
) as exe:
cloudpickle_register(ind=1)
fs1 = exe.submit(mpi_funct, 1)
self.assertFalse(fs1.done())
self.assertEqual(fs1.result(), [(1, 2, 0), (1, 2, 1)])
self.assertTrue(fs1.done())
self.assertEqual(len(os.listdir("executorlib_cache")), 4)

def tearDown(self):
shutil.rmtree("executorlib_cache", ignore_errors=True)
Loading