[INF] Enforce dependency on pandas 3.0.0#1601
Conversation
ericmjl
left a comment
There was a problem hiding this comment.
Thank you, @raffaelemancuso! I'm approving. @samukweku can I check if this will have any negative impact? I think it's time we pin to a newer version of pandas.
|
Hi @raffaelemancuso! The CI is failing because the To fix, please run: pixi lock
git add pixi.lock
git commit -m "[INF] Update pixi.lock for pandas>=3.0.0 dependency"
git pushThis will update the lock file to reflect the new |
|
I have updated Python to >= 3.11 because pandas >= 3.0 depends on Python >= 3.11 |
Done Is there a particular reason why we use It feels much clunkier (even to install it), and I believe the vast majority of projects is using |
|
It's an early decision I made when I was getting familiar with pixi. Always happy to retool later. I'm paying close attention to the state of uv, given that the team was acquihired by OpenAI, so I'm not really sure what will happen of it. Nonetheless, thank you for handling this! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1601 +/- ##
==========================================
- Coverage 87.56% 85.88% -1.68%
==========================================
Files 95 125 +30
Lines 6819 9892 +3073
==========================================
+ Hits 5971 8496 +2525
- Misses 848 1396 +548 🚀 New features to boost your workflow:
|
Bump requires-python to >=3.11 and pin pandas>=3.0.0 in project dependencies. Regenerate pixi.lock and remove redundant pixi pandas pin. Fixes pyjanitor-devs#1597 Co-authored-by: Cursor <cursoragent@cursor.com>
|
@raffaelemancuso, thanks for this! The CI failures are both infra-related, not code issues:
All three test matrices (py311/312/313) pass cleanly. The change is straightforward -- just tightening the pandas constraint to match reality. I've already rebased onto @samukweku, wdyt? Shall we merge this one? |
PR Description
Please describe the changes proposed in the pull request:
This PR resolves #1597 .
PR Checklist
Please ensure that you have done the following:
<your_username>:dev, but rather from<your_username>:<feature-branch_name>.AUTHORS.md.CHANGELOG.mdunder the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.