Skip to content

[TST] HealthCheck failure fix in test_ecdf_string#1609

Open
mjsr84 wants to merge 2 commits into
pyjanitor-devs:devfrom
mjsr84:fix/test-ecdf-string-health-check
Open

[TST] HealthCheck failure fix in test_ecdf_string#1609
mjsr84 wants to merge 2 commits into
pyjanitor-devs:devfrom
mjsr84:fix/test-ecdf-string-health-check

Conversation

@mjsr84
Copy link
Copy Markdown

@mjsr84 mjsr84 commented May 12, 2026

Add @settings(suppress_health_check=[HealthCheck.too_slow], deadline=None)
to test_ecdf_string. Without it, Hypothesis raises FailedHealthCheck
because series(dtype=object) is slow to generate. Also imports HealthCheck.

PR Description

Please describe the changes proposed in the pull request:

  • 'test_ecdf_string' was missing a '@settings' decorator, causing Hypothesis to raise FailedHealthCheck: Input generation is slow'
  • 'series(dtype=object)' is slow to generate without 'suppress_health_check=[HealthCheck.too_slow]', Hypothesis aborts before running any examples
  • Fix matches the pattern already used in 'test_ecdf' in the same file
  • Root cause: Dec 2025 commit that edited 'test_ecdf' for dtype changes presumably accidentally dropped the decorator from 'test_ecdf_string'

This PR resolves unreported issue.

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

mjsr84 added 2 commits May 11, 2026 23:58
>
> Add @settings(suppress_health_check=[HealthCheck.too_slow], deadline=None)
> to test_ecdf_string. Without it, Hypothesis raises FailedHealthCheck
> because series(dtype=object) is slow to generate. Also imports HealthCheck.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.76%. Comparing base (901f4b3) to head (4dbc2d0).
⚠️ Report is 183 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1609      +/-   ##
==========================================
- Coverage   87.56%   85.76%   -1.80%     
==========================================
  Files          95      125      +30     
  Lines        6819     9892    +3073     
==========================================
+ Hits         5971     8484    +2513     
- Misses        848     1408     +560     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant