Bugfix/Cleanup/Polish Pass by JustAHuman-xD · Pull Request #1071 · pylonmc/pylon

JustAHuman-xD · 2026-06-29T19:23:52Z

Went through a lot of pylon (though attempting to exclude a lot of what's being touched by electricity) and fixed various bugs, improved performance, and just cleaned up code

A few things were rewritten to address major bugs or issues

…mance stuff

JustAHuman-xD · 2026-06-29T19:52:20Z

Rewrote this as there were a lot of edge cases with the effect, its removal, cooldown, etc, that were not properly handled

JustAHuman-xD · 2026-06-29T19:52:38Z

Rewrote this to fix #779

JustAHuman-xD · 2026-06-29T19:53:22Z

There were a lot of oddities with how Rune & the related interfaces worked, as well as just undocumented behavior for the implementing class, I rewrote it to be a lot more straightforward, cleaner, etc

JustAHuman-xD · 2026-06-29T19:53:37Z

This is the new version of the old RuneApplicable interface

JustAHuman-xD · 2026-06-29T19:54:16Z

I rewrote and abstracted this into VeinminerTool so that we can do other tools which utilize the same logic while fixing a few bugs with the original implementation

JustAHuman-xD · 2026-06-29T20:10:18Z

-            ItemStack input = fuelInputHatch.inventory.getItem(0);
-            if (input != null && !RebarItem.isRebarItem(input)) {
+            ItemStack input = fuelInputHatch.inventory.getUnsafeItem(0);
+            if (input != null && !RebarItem.isRebarItemAndIsNot(input, VanillaFurnaceFuel.class)) {


fixed this not respecting VanillaFurnaceFuel

JustAHuman-xD · 2026-06-29T20:10:55Z

    public void tryConsumeFuel() {
        ItemInputHatch inputHatch = getMultiblockComponentOrThrow(ItemInputHatch.class, ITEM_INPUT);
-        ItemStack stack = inputHatch.inventory.getItem(0);
-        if (stack == null || RebarItem.isRebarItem(stack) || stack.isEmpty()) {
+        ItemStack stack = inputHatch.inventory.getUnsafeItem(0);
+        if (stack == null || RebarItem.isRebarItemAndIsNot(stack, VanillaFurnaceFuel.class)) {
            return;
        }

        ItemType itemType = stack.getType().asItemType();
-        if (itemType == null) {
+        if (itemType == null || !itemType.isFuel()) {
            return;
        }

-        inputHatch.inventory.setItem(new MachineUpdateReason(), 0, stack.subtract());
+        RebarUtils.unsafeSubtract(inputHatch.inventory, 0, 1);
        startProcess(itemType.getBurnDuration() / 10);
    }


Fixed this consuming any item regardless of if it was fuel or not

JustAHuman-xD · 2026-06-29T20:11:18Z

+        ItemType type = fuel.getType().asItemType();
+        if (type == null || !type.isFuel()|| RebarItem.isRebarItemAndIsNot(fuel, VanillaFurnaceFuel.class)) {
+            return;
+        }
+
+        RebarUtils.unsafeSubtract(fuelInventory, 0, 1);


Fixed this not respecting if the item was actually fuel

JustAHuman-xD · 2026-06-29T20:11:55Z

-            gypsum.remove();
-            BlockStorage.placeBlock(against, PylonKeys.BLOOMERY);
-            fire.setType(Material.AIR);
+            if (BlockStorage.placeBlock(against, PylonKeys.BLOOMERY) != null) {
+                Item gypsumDust = (Item) gypsumDusts.iterator().next();
+                ItemStack gypsumStack = gypsumDust.getItemStack();
+                gypsumStack.subtract();
+                gypsumDust.setItemStack(gypsumStack);
+                fire.setType(Material.AIR);
+            }


fixed this not respecting it the bloomery placement fails

JustAHuman-xD · 2026-06-29T20:12:54Z

+        ItemType type = fuel.getType().asItemType();
+        if (type == null || !type.isFuel() || RebarItem.isRebarItemAndIsNot(fuel, VanillaFurnaceFuel.class)) {
+            return;
+        }


Fixed it not respecting if it was a fuel item or not

JustAHuman-xD · 2026-06-29T20:16:46Z

@@ -57,24 +57,31 @@ public void removeEffect(@NotNull Player player) {
    public static class FarmingTalismanListener implements Listener {
        @EventHandler
        public void onBlockBreak(BlockDropItemEvent event) {


Fixed a bug where the trigger sound would play more than once

JustAHuman-xD · 2026-06-29T20:17:51Z

    /**
-     * This method is called when an item is inserted into the pedestal. It can be used to check if the item is
-     * allowed to be inserted.
-     *
-     * @return true if the item can be inserted into the pedestal, false otherwise
+     * @return true if the item can be placed on the pedestal, false otherwise
     */
-    public boolean isIllegalItem(Player player, ItemStack stack) {
-        return false;
+    public boolean canPlaceItem(Player player, ItemStack stack) {
+        return true;
    }


Fixed an issue where the javadoc was telling the opposite of what the method actually was

JustAHuman-xD · 2026-06-29T20:19:03Z

Fixed a few bugs where the fireproof rune only considered an item to be fireproof if it was only fireproof (i.e. not immune to other different damage types) and where when making an item fireproof it would clear the existing damage immunities if they were there

JustAHuman-xD · 2026-06-29T20:19:48Z

-                if (curStack.getItemMeta().getPersistentDataContainer().has(SOULBOUND_KEY)) {
-                    event.getItemsToKeep().add(curStack);
-                    curItem.remove();
+        @EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true)


Fixed a bug where this might operate when the player death event was cancelled

JustAHuman-xD · 2026-06-29T20:20:24Z

            .set(DataComponentTypes.FIREWORK_EXPLOSION, FireworkEffect.builder()
                    .withColor(Color.PURPLE)
                    .build())
+            .editPdc(pdc -> pdc.set(SoulboundRune.SOULBOUND_KEY, RebarSerializers.BOOLEAN, true))


Fixed a bug where the soulbound rune wasnt soulbound

JustAHuman-xD · 2026-06-29T20:21:40Z

+                for (ItemStack drop : event.getDrops()) {
+                    drainBlock.getWorld().dropItemNaturally(drainBlock.getLocation().toCenterLocation(), drop);
+                }


fixed a bug where this wouldn't respect any drops added by listeners of the event

JustAHuman-xD · 2026-06-29T20:22:56Z

+        FluidLevelChangeEvent event = new FluidLevelChangeEvent(placeBlock, material.createBlockData());
+        if (event.callEvent()) {
+            placeBlock.setBlockData(event.getNewData());


Fixed a bug where this wouldn't respect any modifications by listeners of the event

JustAHuman-xD · 2026-07-02T23:43:55Z

This would supercede #1060 and #1069

balugaq · 2026-07-08T06:28:07Z

+    }
+
+    private boolean cannotVeinMine(Player player, Set<BlockPosition> vein) {
+        return vein.size() >= getMaxVeinSize() || getStack().isEmpty() || RebarUtils.hasOneDurabilityLeft(getStack()) || !getStack().equals(player.getInventory().getItemInMainHand());


It seems !getStack().equals(player.getInventory().getItemInMainHand()) always returns true
and RebarUtils.hasOneDurabilityLeft(getStack()) may not work for the tool may be enchanted with Unbreaking or in case that other plugins modify it.

QQ20260708-142726.mp4

the equals is not guaranteed to be true precisely because other plugins may interfere, I can remove the one durability clause and delay the breakage by a tick if you want instead, I just preferred it to all happen at the same time

just remove the one durability clause, getStack().isEmpty() will stop the veinmining action.

Can't do that because that causes the "one durability breaks 2 blocks bug"

It is because the origin event also breaks a block.
Just cancel the event pass into onBreakBlock, and we can take control of the whole break action. (also needs to make some changes at OFFSETS, put the nearest direction in the front)

I mean just search the blocks like how water spread.

I fail to see why or how I would do that. Also water spreads in a very weird and context specific way that does not really apply here

water spreads in a very weird and context specific way

What context you mean?

I fail to see why or how I would do that

see https://github.com/pylonmc/pylon/pull/1060/changes

That still does effectively the same recursion, is less flexible, and also just isn't how water spreads

I don't think it causes recursion and it's less flexible., can you give some examples..?

balugaq · 2026-07-08T06:36:07Z

+    public abstract boolean canVeinmine(Block root);
+    public boolean isInVein(Block root, Block block) {
+        return root.getType() == block.getType();
+    }


Needs some docs on these two methods, I was confused before I realized the difference of canVeinmine and isInVein

I mean I can add them but the method name & signature are entirely different & imply completely different things so I don't really know how you'd get confused

canVeinmine means for me: if the block can be veinmined.
I don't know what is root block means at first:

it only means the first block I break

or does the block near the first block is also considered as root block?

and when is it called:

it only checks the first block I break

or does this also used to check if the block can be veinmined when each time called tryVeinMine?

I would prefer to rename canVeinmine to canStartVeinmine

balugaq · 2026-07-08T06:38:34Z

+        VEIN_MINING.remove(playerId);
+    }
+
+    public void tryVeinMine(Player player, Block root, Location rootLocation, Block block, Set<BlockPosition> vein) {


Breaks too many blocks
https://github.com/user-attachments/assets/dc6926e7-ecff-43ec-823e-037ef2bb6d93

Hm that wasn't happening for me, are you sure you didn't change the setting for the vein limit or something?

Does no change the setting. and it works well the first time I use it, I'm trying to reproduce it.

The set vein is used to record what block is broken. But a position may be visited many times, which causes player.breakBlock(block) returns false and remove the position

No because vein is a set and if it fails to add to it, it returns, also it it was already broken and air it wouldn't even reach player break block

Just find something weird, it logs continuously but suddenly vein.size turns to 2, unless it was cleared I can't find any other remove action in the code...

Well, now I know why.

balugaq · 2026-07-08T07:11:32Z

+            return;
+        }
+
+        BlockPosition position = new BlockPosition(block);


not sure if it needs a world border check

Co-authored-by: balugaq <129668183+balugaq@users.noreply.github.com>

JustAHuman-xD and others added 15 commits June 21, 2026 10:29

VeinminingTool & various small bits

c4bbcbe

Rewrite runes

c972a59

one more javadoc line

dd00a4c

Talisman pass

ee339b7

pylon from stack usage

1fe298d

custom model data stuff

ca409e3

smelting & storage machines

f72bac5

boost cargo performance #1

12cc13c

boost cargo performance #2

d79534e

some fluid stuff

5df7255

building blocks

e8192ec

smol fix

fe85abb

fix tons of fuel consuming blocks, lots more virtual inventory perfor…

c701740

…mance stuff

notify windows

6b4290d

also check if broken explicitly

7418632

JustAHuman-xD commented Jun 29, 2026

View reviewed changes

This was referenced Jul 2, 2026

Fix LumberAxe #1060

Closed

Change event priority for Lumber Axe block break handler #1069

Closed

JustAHuman-xD added 2 commits July 3, 2026 11:10

Merge branch 'master' into human/pylon-polish-pass

b1c3d9a

Update CastingRecipe.java

743b245

JustAHuman-xD added 4 commits July 3, 2026 14:07

lel

cf3408a

tick based not millis based

2ff60dc

oops

f71b2c4

rotateable fluid voider

51d58e8

LordIdra reviewed Jul 3, 2026

View reviewed changes

pr comments

3c32049

balugaq requested changes Jul 4, 2026

View reviewed changes

JustAHuman-xD added 3 commits July 7, 2026 23:33

probably intended this to be the protected constructor

720b399

block data qol & pr comment

f52b860

lumber axe & veinminingtool improvements/fixes

d1f05c6

JustAHuman-xD requested review from LordIdra and balugaq July 8, 2026 06:08

balugaq requested changes Jul 8, 2026

View reviewed changes

balugaq reviewed Jul 8, 2026

View reviewed changes

balugaq mentioned this pull request Jul 8, 2026

Cargo exception: java.lang.IllegalStateException: Expected node to have one traversable face but had 2 pylonmc/rebar#872

Open

balugaq reviewed Jul 8, 2026

View reviewed changes

Comment thread src/main/java/io/github/pylonmc/pylon/content/tools/VeinminingTool.java

balugaq reviewed Jul 8, 2026

View reviewed changes

Comment thread src/main/java/io/github/pylonmc/pylon/content/tools/VeinminingTool.java Outdated

Update VeinminingTool.java

36fc5e3

Co-authored-by: balugaq <129668183+balugaq@users.noreply.github.com>

balugaq approved these changes Jul 8, 2026

View reviewed changes

Uh oh!

Conversation

JustAHuman-xD commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JustAHuman-xD commented Jul 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

balugaq Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

JustAHuman-xD commented Jun 29, 2026 •

edited

Loading

balugaq Jul 8, 2026 •

edited

Loading