Skip to content

Commit d77a391

Browse files
Attribute the agreement numbers to the right comparison
1 parent 93ac2bd commit d77a391

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

examples/variational_inference/streaming_dataset.ipynb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -400,14 +400,14 @@
400400
"source": [
401401
"That line is only the bare array. Actual peak RSS is higher, because of the\n",
402402
"framework and PyTensor's resident copy, and it hits the RAM ceiling sooner. To get\n",
403-
"the real number on public data, I measured peak memory on the\n",
403+
"the real number on public data, we measured peak memory on the\n",
404404
"[Criteo 1TB Click Logs](https://huggingface.co/datasets/criteo/CriteoClickLogs), a\n",
405405
"standard out-of-core learning benchmark, with the same logistic model (13 numeric\n",
406406
"features plus the click label). Streaming through the `DataLoader` stayed flat at\n",
407407
"about 0.7 GB across a sweep from 1M to 150M rows. The in-RAM `pm.Minibatch` baseline\n",
408408
"rose linearly to 15.7 GB at 150M rows, about 21 times more, and extrapolates to\n",
409-
"out-of-memory near 238M rows on a 26 GB machine. The two posteriors agree to\n",
410-
"within ADVI noise (correlation 0.999 across all 14 coefficients). Criteo is\n",
409+
"out-of-memory near 238M rows on a 26 GB machine. The streaming and in-RAM posteriors agree coefficient for coefficient; the\n",
410+
"largest gap is about 0.1, on the intercept. Criteo is\n",
411411
"public, so anyone can rerun this.\n",
412412
"\n",
413413
"## When to use it\n",

examples/variational_inference/streaming_dataset.myst.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -202,14 +202,14 @@ fig.tight_layout();
202202

203203
That line is only the bare array. Actual peak RSS is higher, because of the
204204
framework and PyTensor's resident copy, and it hits the RAM ceiling sooner. To get
205-
the real number on public data, I measured peak memory on the
205+
the real number on public data, we measured peak memory on the
206206
[Criteo 1TB Click Logs](https://huggingface.co/datasets/criteo/CriteoClickLogs), a
207207
standard out-of-core learning benchmark, with the same logistic model (13 numeric
208208
features plus the click label). Streaming through the `DataLoader` stayed flat at
209209
about 0.7 GB across a sweep from 1M to 150M rows. The in-RAM `pm.Minibatch` baseline
210210
rose linearly to 15.7 GB at 150M rows, about 21 times more, and extrapolates to
211-
out-of-memory near 238M rows on a 26 GB machine. The two posteriors agree to
212-
within ADVI noise (correlation 0.999 across all 14 coefficients). Criteo is
211+
out-of-memory near 238M rows on a 26 GB machine. The streaming and in-RAM posteriors agree coefficient for coefficient; the
212+
largest gap is about 0.1, on the intercept. Criteo is
213213
public, so anyone can rerun this.
214214

215215
## When to use it

0 commit comments

Comments
 (0)