Skip to content

Updating Discrete choice issue to fix parameter identification issue#781

Merged
juanitorduz merged 5 commits intopymc-devs:mainfrom
NathanielF:fix-discrete-choice
Mar 24, 2025
Merged

Updating Discrete choice issue to fix parameter identification issue#781
juanitorduz merged 5 commits intopymc-devs:mainfrom
NathanielF:fix-discrete-choice

Conversation

@NathanielF
Copy link
Copy Markdown
Contributor

@NathanielF NathanielF commented Mar 21, 2025

Better handling of parameter identification in Discrete choice model

Adding a fix for parameter identification in the discrete choice notebook

Related to this issue and the PyMC discourse discussion:
https://discourse.pymc.io/t/inconsistencies-w-r-in-discrete-choice-and-random-utility-pymc-example/16488/4

#780

and older discussion here: #617

Helpful links


📚 Documentation preview 📚: https://pymc-examples--781.org.readthedocs.build/en/781/

Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
@NathanielF
Copy link
Copy Markdown
Contributor Author

A relatively small change to fix the issue above. Tagging @drbenvincent as it's of interest from the causal inference pov and @OriolAbril because i think you reviewed the original PR.

Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
@NathanielF
Copy link
Copy Markdown
Contributor Author

Thanks so much @juanitorduz it's a small change but very important for these models! Would you be able to merge it for me, i don't think i have permissions for that on this repo.

@juanitorduz juanitorduz merged commit acc0594 into pymc-devs:main Mar 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants