Updating Discrete choice issue to fix parameter identification issue#781
Merged
juanitorduz merged 5 commits intopymc-devs:mainfrom Mar 24, 2025
Merged
Updating Discrete choice issue to fix parameter identification issue#781juanitorduz merged 5 commits intopymc-devs:mainfrom
juanitorduz merged 5 commits intopymc-devs:mainfrom
Conversation
Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
Contributor
Author
|
A relatively small change to fix the issue above. Tagging @drbenvincent as it's of interest from the causal inference pov and @OriolAbril because i think you reviewed the original PR. |
Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
Signed-off-by: Nathaniel <NathanielF@users.noreply.github.com>
juanitorduz
approved these changes
Mar 24, 2025
Contributor
Author
|
Thanks so much @juanitorduz it's a small change but very important for these models! Would you be able to merge it for me, i don't think i have permissions for that on this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better handling of parameter identification in Discrete choice model
Adding a fix for parameter identification in the discrete choice notebook
Related to this issue and the PyMC discourse discussion:
https://discourse.pymc.io/t/inconsistencies-w-r-in-discrete-choice-and-random-utility-pymc-example/16488/4
#780
and older discussion here: #617
Helpful links
📚 Documentation preview 📚: https://pymc-examples--781.org.readthedocs.build/en/781/