[WIP] Bugfix for 5.19-5.22#160
Open
oadams wants to merge 1 commit into
Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spotted what I think is a bug in the Chapter 5 notebook. In the book, sections 5.19-5.22 do counterfactual modeling with a model where A -> M and A -> D <- M. The predictor A is tweaked and the total effect on D is observed. This total effect comes from the direct link between A and D, but is also mediated by an indirect link via M. That is, values of M need to be simulated as well and their effect on D.
The bug was that it appeared as though the values for M were not being simulated. The difference in the resulting plots in 5.22 is small, but from a modeling perspective it's quite distinct.
This PR isn't quite ready for merge, because my changes break subsequent code from 5.23 onwards. But I am putting the PR up now in the hope of getting feedback on whether I'm doing it the correct way before changing the subsequent code.
Note I haven't run pre-commit checks yet, so don't merge in current state.