Reject variable names with `/` in it

[ricardoV94]

Description

Xarray / DataTree treat this as hierarchical delimiters, so we can't have them for regular variable names.

CC @aloctavodia

[Chirag3841]

@ricardoV94 Here, we can add a validation in _validate_name() to check if "/" exists in the variable name and raise a ValueError if it does. This ensures all variable names are filtered at a central point. Optionally, add a backup check in add_named_variable() for extra safety.

@staticmethod
def _validate_name(name):
    if name.endswith(":"):
        raise KeyError("name should not end with `:`")
    if "/" in name:
        raise ValueError(f"Variable name '{name}' cannot contain '/'.")
    return name

[ricardoV94]

validate_name seems to be the right place

[Chirag3841]

validate_name seems to be the right place
@ricardoV94
I meant adding validation for "/" in _validate_name, and adding a corresponding test.

For the test, I plan to add:

def test_variable_name_with_slash(self):
    with pm.Model():
        with pytest.raises(ValueError, match="cannot contain '/' "):
            pm.Normal("a/b")

inside the TestNested class, alongside other invalid name tests.

[ricardoV94]

Wdym?

[Chirag3841]

Wdym?

I meant adding validation for "/" in _validate_name, and adding a corresponding test for it.
The test checks that creating a variable like "a/b" raises a ValueError.

[ricardoV94]

Got it, yeah sounds good