Use nutpie by default#8111
Conversation
|
|
|
@ricardoV94 It implements the auto-selection logic: Let me know what you think! |
| except ImportError: | ||
| MemoryStore = type("MemoryStore", (), {}) | ||
|
|
||
| def _nutpie_is_installed() -> bool: |
There was a problem hiding this comment.
nutpie will be a default dependency once we do these changes, no need to check if it's installed
| if ( | ||
| exclusive_nuts | ||
| and _nutpie_is_installed() | ||
| and (compile_kwargs is None or not compile_kwargs) |
There was a problem hiding this comment.
compile kwargs is not enough to rule out nutpie. Only if it implies a pytensor compilation mode that is not numba or jax backend. Something like nutpie_compatibile_mode = isinstance(get_mode(compile_kwargs.get("mode")).linker, JAXLinker| NumbaLinker)
There was a problem hiding this comment.
We also need to propagate this information into the backend kwarg for nutpie
| @@ -0,0 +1,91 @@ | |||
| # Copyright 2024 - present The PyMC Developers | |||
There was a problem hiding this comment.
no reason for a new test file, it should be in test_mcmc, or whatever file tests sample functionality now
Refactor tests to improve mocking and assertions for sample function.
2b5f03f to
e566bf7
Compare
|
@ricardoV94 T
All CI checks (Docs, Pre-commit, etc.) are now passing (green). Ready for re-review! |
|
@ricardoV94 wdyt, would be nice to get this default on the v6 branch. |
|
Closing in favor of #8248 |

Closes 8079