Explicit rng in expand_dist_dims#8255
Merged
ricardoV94 merged 1 commit intopymc-devs:v6from Apr 17, 2026
Merged
Conversation
ricardoV94
force-pushed
the
censored_xdist_rng_api
branch
from
4c9caa6 to
3a915cc
Compare
ricardoV94
added
no releasenotes
Documentation build overview
217 files changed ·
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v6 #8255 +/- ##
=====================================
Coverage ? 91.71%
=====================================
Files ? 124
Lines ? 19962
Branches ? 0
=====================================
Hits ? 18309
Misses ? 1653
Partials ? 0
🚀 New features to boost your workflow:
|
jessegrabowski
approved these changes
Apr 17, 2026
| new_dist_op = type(dist.owner.op)(**dist_props) | ||
| _old_rng, *params_and_dim_lengths = dist.owner.inputs | ||
| new_rng = None # We don't propagate the old RNG, because we don't want the new and old dists to be correlated | ||
| # We don't propagate the old RNG, because we don't want the new and old dists to be correlated |
Member
There was a problem hiding this comment.
don't change anything but this comment is very strange, that's not how prng is supposed to work at all?
Member
Author
There was a problem hiding this comment.
you shouldn't reuse the same rng in multiple places, even if one is going to be dead code, just to be sure we don't
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not using strict filterwarnings, showed up in pymc-devs/pymc-extras#668