Fix marimo progress bar issues#8298
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (40.90%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8298 +/- ##
==========================================
- Coverage 91.78% 91.73% -0.06%
==========================================
Files 125 125
Lines 20428 20448 +20
==========================================
+ Hits 18749 18757 +8
- Misses 1679 1691 +12
🚀 New features to boost your workflow:
|
883b3f9 to
555b1ed
Compare
Member
Author
|
Need to change the windows CI runners I think |
555b1ed to
7f1a194
Compare
williambdean
approved these changes
May 19, 2026
Member
Author
the nutpie fix is just for nutpie because it calls it from a thread. I don't think we do this anywhere ourselves. if we start doing so we can port the code over |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes display of nutpie progress bar in marimo, reported in https://discourse.pymc.io/t/is-progress-bar-in-marimo-broken-for-everyone-with-v6-0-0-or-its-just-me/17715
And another issue I found while debugging: speed/elapsed kept drifting fro finished bars (more obvious in sequential sampling, but also present in parallel)
Before:
Screencast.From.2026-05-16.15-18-33.mp4
After:
Screencast.From.2026-05-16.15-02-40.mp4