Skip to content

Fix marimo progress bar issues#8298

Merged
ricardoV94 merged 2 commits into
pymc-devs:mainfrom
ricardoV94:marimo_nutpie_fix
May 19, 2026
Merged

Fix marimo progress bar issues#8298
ricardoV94 merged 2 commits into
pymc-devs:mainfrom
ricardoV94:marimo_nutpie_fix

Conversation

@ricardoV94
Copy link
Copy Markdown
Member

@ricardoV94 ricardoV94 commented May 16, 2026

Fixes display of nutpie progress bar in marimo, reported in https://discourse.pymc.io/t/is-progress-bar-in-marimo-broken-for-everyone-with-v6-0-0-or-its-just-me/17715

And another issue I found while debugging: speed/elapsed kept drifting fro finished bars (more obvious in sequential sampling, but also present in parallel)

Before:

Screencast.From.2026-05-16.15-18-33.mp4

After:

Screencast.From.2026-05-16.15-02-40.mp4

@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented May 16, 2026

Documentation build overview

📚 pymc | 🛠️ Build #32735807 | 📁 Comparing 7f1a194 against latest (a65e8b6)

  🔍 Preview build  

2 files changed
± glossary.html
± contributing/jupyter_style.html

@ricardoV94 ricardoV94 marked this pull request as draft May 16, 2026 13:27
@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Codecov Report

❌ Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.73%. Comparing base (169e901) to head (7f1a194).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pymc/progress_bar/marimo_progress.py 0.00% 9 Missing ⚠️
pymc/progress_bar/progress.py 69.23% 4 Missing ⚠️

❌ Your patch check has failed because the patch coverage (40.90%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8298      +/-   ##
==========================================
- Coverage   91.78%   91.73%   -0.06%     
==========================================
  Files         125      125              
  Lines       20428    20448      +20     
==========================================
+ Hits        18749    18757       +8     
- Misses       1679     1691      +12     
Files with missing lines Coverage Δ
pymc/progress_bar/progress.py 83.17% <69.23%> (-0.99%) ⬇️
pymc/progress_bar/marimo_progress.py 16.57% <0.00%> (-0.77%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 force-pushed the marimo_nutpie_fix branch 2 times, most recently from 883b3f9 to 555b1ed Compare May 16, 2026 14:43
@ricardoV94
Copy link
Copy Markdown
Member Author

Need to change the windows CI runners I think

@ricardoV94 ricardoV94 force-pushed the marimo_nutpie_fix branch from 555b1ed to 7f1a194 Compare May 18, 2026 11:27
@ricardoV94 ricardoV94 marked this pull request as ready for review May 18, 2026 20:59
Copy link
Copy Markdown
Contributor

@williambdean williambdean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. So is this also for the PyMC sampler as well? Or just nutpie where then it is safe to do the import.

@ricardoV94
Copy link
Copy Markdown
Member Author

ricardoV94 commented May 19, 2026

Seems reasonable. So is this also for the PyMC sampler as well? Or just nutpie where then it is safe to do the import.

the nutpie fix is just for nutpie because it calls it from a thread. I don't think we do this anywhere ourselves. if we start doing so we can port the code over

@ricardoV94 ricardoV94 merged commit d535148 into pymc-devs:main May 19, 2026
41 of 42 checks passed
@ricardoV94 ricardoV94 deleted the marimo_nutpie_fix branch May 19, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants