fix: ensure raveled array uses float64 dtype in DictToArrayBijection (closes #8337)#8338
Draft
botbikamordehai2-sketch wants to merge 1 commit into
Draft
Conversation
Member
|
Users nay be trying to sample in float32 or all variables could be discrete. upcast dtype should be inferred from input types not forced |
Member
|
Also the issue explanation seems doubtful. Have you shown it? |
ricardoV94
marked this pull request as draft
July 7, 2026 09:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a PyMC model uses a length-one dimensioned vector RV as a non-sequence in
pytensor.scan, the raveled NUTS setup fails becauseDictToArrayBijection.mapdoes not enforce a consistent float64 dtype. The original code usednp.concatenateon raveled arrays that may have incompatible dtypes (e.g., object from a 1-element vector), causing downstream errors.Fix
Forced the raveled arrays to
np.float64before concatenation, and initialized the empty array withdtype=np.float64. This ensures the bijection always works with the expected numeric type.Closes #8337