Docs: Add Staggered DiD sensitivity checks walkthrough#846
Open
drbenvincent wants to merge 2 commits into
Open
Docs: Add Staggered DiD sensitivity checks walkthrough#846drbenvincent wants to merge 2 commits into
drbenvincent wants to merge 2 commits into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
Bot
added
OSS_PRODUCT
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #846 +/- ##
=======================================
Coverage 94.60% 94.60%
=======================================
Files 80 80
Lines 12764 12764
Branches 770 770
=======================================
Hits 12076 12076
Misses 485 485
Partials 203 203 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- Replace misleading PlaceboInTime reference with clear statement that only PreTreatmentPlaceboCheck and PriorSensitivity apply to staggered DiD - Add "If this check fails" subsection with concrete troubleshooting steps: inspect event-study plot for directional pre-trends, check pre-treatment window sparsity, revisit outcome model specification, and compare results under alternative priors Made-with: Cursor
drbenvincent
force-pushed
the
staggered-did-sensitivity-checks-walkthrough
branch
from
0f917f5 to
72d51c1
Compare
5 tasks
drbenvincent
added a commit
that referenced
this pull request
Apr 30, 2026
Adds a sensitivity-analysis section to sc_pymc.ipynb that walks through the pipeline API (EstimateEffect -> SensitivityAnalysis -> GenerateReport) with PlaceboInTime as the SC default check, and documents the other SC-applicable checks (ConvexHullCheck, LeaveOneOut, PlaceboInSpace, PriorSensitivity) with interpretation guidance. Mirrors the structure introduced for Staggered DiD in #846 and links back to the central guide from #818. Includes a runnable pipeline cell and HTML report iframe so the walkthrough demonstrates an end-to-end placebo-in-time check with concrete pass/fail narrative and a five-step "if this check fails" troubleshooting block. Closes #789 Made-with: Cursor
Collaborator
Author
Automated triageRecommendation: Why:
Review focus:
Confidence: high |
drbenvincent
added
the
review:medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a focused sensitivity-check walkthrough for Staggered DiD to the
staggered_did_pymc.ipynbnotebook, addressing #791.This continues the work from #806 (by @arthurmello) and incorporates the review feedback:
PreTreatmentPlaceboCheckwalkthrough using the pipeline API (EstimateEffect→SensitivityAnalysis→GenerateReport)PreTreatmentPlaceboCheckandPriorSensitivityapply to staggered DiD, and that other checks likePlaceboInTimeandLeaveOneOutare for different estimatorsPriorSensitivitySupersedes #806. Closes #791.
Test plan
prek run --all-filespasses (verified locally)Made with Cursor