docs: remove panel_fixed_effects bibliography cell#905
Closed
anevolbap wants to merge 1 commit into
Closed
Conversation
…book Closes the remaining piece of pymc-labs#884. The trailing References cell with :::{bibliography} was added in pymc-labs#628 after the global bibliography consolidation in pymc-labs#834. Inline {cite:p} references already resolve against docs/source/references.rst, so the cell is redundant. sensitivity_checks.md was already cleaned up separately. Notebook re-executed end-to-end in the CausalPy env to refresh outputs.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
anevolbap
changed the title
github-actions
Bot
added
the
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
=======================================
Coverage 94.87% 94.87%
=======================================
Files 85 85
Lines 13174 13174
Branches 793 793
=======================================
Hits 12499 12499
Misses 479 479
Partials 196 196 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Documentation build overview
25 files changed ·
|
Contributor
Author
|
Superseded by #909, which restores per-document bibliographies across the docs and consequently keeps the bibliography cell in panel_fixed_effects.ipynb that this PR was removing. The cleanup is no longer needed under that approach. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #884.
Summary
Removes the trailing
## Referencescell with:::{bibliography}frompanel_fixed_effects.ipynb. The cell was added in #628 after #834 had centralised references intodocs/source/references.rst. Inline{cite:p}calls already resolve against the global page, so the cell is redundant.sensitivity_checks.md, the other file named in #884, was already cleaned up separately.Changes
docs/source/notebooks/panel_fixed_effects.ipynb: drop the trailing References cell.CausalPyenv so saved outputs are fresh.Verification
grep -rn ":::{bibliography}" docs/source/notebooks docs/source/knowledgebasereturns no matches.prek run --files docs/source/notebooks/panel_fixed_effects.ipynbpasses (notablyValidate notebook schema).make htmlbuilds cleanly: 15 pre-existing autodoc/toctree warnings, no newbibtex.duplicate_*warnings.