Skip to content

fix: Ensure position coordinates are propagated to zarr coordinateTransforms and OME StageLabel#134

Open
tlambert03 wants to merge 3 commits into
pymmcore-plus:mainfrom
tlambert03:translate-propogation
Open

fix: Ensure position coordinates are propagated to zarr coordinateTransforms and OME StageLabel#134
tlambert03 wants to merge 3 commits into
pymmcore-plus:mainfrom
tlambert03:translate-propogation

Conversation

@tlambert03
Copy link
Copy Markdown
Member

partially addresses #132

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 14, 2026

Merging this PR will improve performance by 60.65%

⚡ 2 improved benchmarks
✅ 21 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
test_bench_append[t5_c2_z3_xy256-tensorstore] 90.9 ms 56.6 ms +60.65%
test_bench_append[3d_chunking-acquire-zarr] 742.6 ms 530.6 ms +39.95%

Comparing tlambert03:translate-propogation (37d3e76) with main (bac0f39)

Open in CodSpeed

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.52%. Comparing base (bac0f39) to head (37d3e76).

Files with missing lines Patch % Lines
src/ome_writers/_backends/_yaozarrs.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   97.52%   97.52%   -0.01%     
==========================================
  Files          21       21              
  Lines        2630     2664      +34     
==========================================
+ Hits         2565     2598      +33     
- Misses         65       66       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 changed the title Ensure position coordinates are propagated to zarr coordinateTransforms and OME StageLabel fix: Ensure position coordinates are propagated to zarr coordinateTransforms and OME StageLabel Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant