src/extra.i: fix leak in JM_get_annot_xref_list().

julian-smith-artifex-com · julian-smith-artifex-com · commit b49a9a0d22d0 · 2026-01-29T14:30:12.000Z
Fixes #4751.
diff --git a/src/extra.i b/src/extra.i
@@ -1337,9 +1337,9 @@ static PyObject *lll_JM_get_annot_xref_list(pdf_obj *page_obj)
 //------------------------------------------------------------------------
 static PyObject* JM_get_annot_xref_list(const mupdf::PdfObj& page_obj)
 {
-    PyObject* names = PyList_New(0);
     if (!page_obj.m_internal)
     {
+        PyObject* names = PyList_New(0);
         return names;
     }
     return lll_JM_get_annot_xref_list( page_obj.m_internal);

Original file line number	Diff line number	Diff line change
`@@ -1337,9 +1337,9 @@ static PyObject lll_JM_get_annot_xref_list(pdf_obj page_obj)`
`1337`	`1337`	`//------------------------------------------------------------------------`
`1338`	`1338`	`static PyObject* JM_get_annot_xref_list(const mupdf::PdfObj& page_obj)`
`1339`	`1339`	`{`
`1340`		`- PyObject* names = PyList_New(0);`
`1341`	`1340`	`if (!page_obj.m_internal)`
`1342`	`1341`	`{`
	`1342`	`+ PyObject* names = PyList_New(0);`
`1343`	`1343`	`return names;`
`1344`	`1344`	`}`
`1345`	`1345`	`return lll_JM_get_annot_xref_list( page_obj.m_internal);`