tests/: removed support for mupdf < 1.26.

Author: julian-smith-artifex-com

tests/test_annots.py

@@ -308,16 +308,13 @@ def test_2270():
                 print(f'{text=}')
                 print(f'{getattr(textpage, "parent")=}')
 
-                if pymupdf.mupdf_version_tuple >= (1, 26):
-                    # Check Annotation.get_textpage()'s <clip> arg.
-                    clip = textBox.rect
-                    clip.x1 = clip.x0 + (clip.x1 - clip.x0) / 3
-                    textpage2 = textBox.get_textpage(clip=clip)
-                    text = textpage2.extractText()
-                    print(f'With {clip=}: {text=}')
-                    assert text == 'ab\n'
-                else:
-                    assert not hasattr(pymupdf.mupdf, 'FZ_STEXT_CLIP_RECT')
+                # Check Annotation.get_textpage()'s <clip> arg.
+                clip = textBox.rect
+                clip.x1 = clip.x0 + (clip.x1 - clip.x0) / 3
+                textpage2 = textBox.get_textpage(clip=clip)
+                text = textpage2.extractText()
+                print(f'With {clip=}: {text=}')
+                assert text == 'ab\n'
 
 
 def test_2934_add_redact_annot():
@@ -492,11 +489,7 @@ def test_4047():
 
 def test_4079():
     path = os.path.normpath(f'{__file__}/../../tests/resources/test_4079.pdf')
-    if pymupdf.mupdf_version_tuple >= (1, 25, 5):
-        path_after = os.path.normpath(f'{__file__}/../../tests/resources/test_4079_after.pdf')
-    else:
-        # 2024-11-27 Expect incorrect behaviour.
-        path_after = os.path.normpath(f'{__file__}/../../tests/resources/test_4079_after_1.25.pdf')
+    path_after = os.path.normpath(f'{__file__}/../../tests/resources/test_4079_after.pdf')
 
     path_out = os.path.normpath(f'{__file__}/../../tests/test_4079_out')
     with pymupdf.open(path_after) as document_after:

tests/test_barcode.py

@@ -4,9 +4,6 @@
 
 
 def test_barcode():
-    if pymupdf.mupdf_version_tuple < (1, 26):
-        print(f'Not testing barcode because {pymupdf.mupdf_version=} < 1.26')
-        return
     path = os.path.normpath(f'{__file__}/../../tests/test_barcode_out.pdf')
 
     url = 'http://artifex.com'

tests/test_general.py

@@ -399,24 +399,17 @@ def test_2108():
         print(f'')
 
     print(f'{pymupdf.mupdf_version_tuple=}')
-    if pymupdf.mupdf_version_tuple >= (1, 21, 2):
-        print('Asserting text==text_expected')
-        assert text == text_expected
-    else:
-        print('Asserting text!=text_expected')
-        assert text != text_expected
+    print('Asserting text==text_expected')
+    assert text == text_expected
 
 
 def test_2238():
     filepath = f'{scriptdir}/resources/test2238.pdf'
     doc = pymupdf.open(filepath)
     wt = pymupdf.TOOLS.mupdf_warnings()
     wt_expected = ''
-    if pymupdf.mupdf_version_tuple >= (1, 26):
-        wt_expected += 'garbage bytes before version marker\n'
-        wt_expected += 'syntax error: expected \'obj\' keyword (6 0 ?)\n'
-    else:
-        wt_expected += 'format error: cannot recognize version marker\n'
+    wt_expected += 'garbage bytes before version marker\n'
+    wt_expected += 'syntax error: expected \'obj\' keyword (6 0 ?)\n'
     wt_expected += 'trying to repair broken xref\n'
     wt_expected += 'repairing PDF document'
     assert wt == wt_expected, f'{wt=}'
@@ -1606,18 +1599,17 @@ def dict_set_path(dict_, *items):
     with open(path_out, 'w') as f:
         json.dump(results, f, indent=4, sort_keys=1)
 
-    if pymupdf.mupdf_version_tuple >= (1, 26):
-        with open(os.path.normpath(f'{__file__}/../../tests/resources/test_open2_expected.json')) as f:
-            results_expected = json.load(f)
-        if results != results_expected:
-            print(f'results != results_expected:')
-            def show(r, name):
-                text = json.dumps(r, indent=4, sort_keys=1)
-                print(f'{name}:')
-                print(textwrap.indent(text, '    '))
-            show(results_expected, 'results_expected')
-            show(results, 'results')
-            assert 0
+    with open(os.path.normpath(f'{__file__}/../../tests/resources/test_open2_expected.json')) as f:
+        results_expected = json.load(f)
+    if results != results_expected:
+        print(f'results != results_expected:')
+        def show(r, name):
+            text = json.dumps(r, indent=4, sort_keys=1)
+            print(f'{name}:')
+            print(textwrap.indent(text, '    '))
+        show(results_expected, 'results_expected')
+        show(results, 'results')
+        assert 0
 
 
 def test_533():
@@ -1773,10 +1765,7 @@ def test_3905():
     else:
         assert 0
     wt = pymupdf.TOOLS.mupdf_warnings()
-    if pymupdf.mupdf_version_tuple >= (1, 26):
-        assert wt == 'format error: cannot find version marker\ntrying to repair broken xref\nrepairing PDF document'
-    else:
-        assert wt == 'format error: cannot recognize version marker\ntrying to repair broken xref\nrepairing PDF document'
+    assert wt == 'format error: cannot find version marker\ntrying to repair broken xref\nrepairing PDF document'
 
 def test_3624():
     path = os.path.normpath(f'{__file__}/../../tests/resources/test_3624.pdf')
@@ -1822,10 +1811,7 @@ def test_4034():
         pixmap2 = document[0].get_pixmap()
     rms = gentle_compare.pixmaps_rms(pixmap1, pixmap2)
     print(f'test_4034(): Comparison of original/cleaned page 0 pixmaps: {rms=}.')
-    if pymupdf.mupdf_version_tuple < (1, 25, 2):
-        assert 30 < rms < 50
-    else:
-        assert rms == 0
+    assert rms == 0
 
 def test_4309():
     document = pymupdf.open()
@@ -1842,11 +1828,8 @@ def test_4263():
     command = f'pymupdf clean -linear {path} {path_out}'
     print(f'Running: {command}')
     cp = subprocess.run(command, shell=1, check=0)
-    if pymupdf.mupdf_version_tuple < (1, 26):
-        assert cp.returncode == 0
-    else:
-        # Support for linerarisation dropped in MuPDF-1.26.
-        assert cp.returncode
+    # Support for linerarisation dropped in MuPDF-1.26.
+    assert cp.returncode
 
 def test_4224():
     path = os.path.normpath(f'{__file__}/../../tests/resources/test_4224.pdf')
@@ -1856,9 +1839,6 @@ def test_4224():
             path_pixmap = f'{path}.{page.number}.png'
             pixmap.save(path_pixmap)
             print(f'Have created: {path_pixmap}')
-    if pymupdf.mupdf_version_tuple < (1, 25, 5):
-        wt = pymupdf.TOOLS.mupdf_warnings()
-        assert wt == 'format error: negative code in 1d faxd\npadding truncated image'
 
 def test_4319():
     # Have not seen this test reproduce issue #4319, but keeping it anyway.

tests/test_memory.py

@@ -225,9 +225,6 @@ def get_stat():
         if pv < (3, 11):
             # Python < 3.11 has less reliable memory usage so we exclude.
             print(f'test_4125(): Not checking on {platform.python_version()=} because < 3.11.')
-        elif pymupdf.mupdf_version_tuple < (1, 25, 2):
-            rss_delta_expected = 4915200 * (len(state.rsss) - 3)
-            assert abs(1 - rss_delta / rss_delta_expected) < 0.15, f'{rss_delta_expected=}'
         else:
             # Before the fix, each iteration would leak 4.9MB.
             rss_delta_max = 100*1000 * (len(state.rsss) - 3)

tests/test_mupdf_regressions.py

@@ -50,11 +50,8 @@ def test_707727():
     print(f'{rms=}', flush=1)
     pix0.save(os.path.normpath(f'{__file__}/../../tests/test_707727_pix0.png'))
     pix1.save(os.path.normpath(f'{__file__}/../../tests/test_707727_pix1.png'))
-    if pymupdf.mupdf_version_tuple >= (1, 25, 2):
-        # New sanitising gives small fp rounding errors.
-        assert rms < 0.05
-    else:
-        assert rms == 0
+    # New sanitising gives small fp rounding errors.
+    assert rms < 0.05
 
 
 def test_707721():

tests/test_pixmap.py

@@ -195,11 +195,7 @@ def product(x, y):
         path_expected = os.path.normpath(f'{__file__}/../../tests/resources/test_3050_expected.png')
         rms = gentle_compare.pixmaps_rms(path_expected, path_out2)
         print(f'{rms=}')
-        if pymupdf.mupdf_version_tuple < (1, 26):
-            # Slight differences in rendering from fix for mupdf bug 708274.
-            assert rms < 0.2
-        else:
-            assert rms == 0
+        assert rms == 0
         wt = pymupdf.TOOLS.mupdf_warnings()
         if (1, 26, 0) <= pymupdf.mupdf_version_tuple < (1, 27):
             assert wt == 'bogus font ascent/descent values (0 / 0)\nPDF stream Length incorrect'
@@ -416,11 +412,7 @@ def test_3448():
     path_diff = os.path.normpath(f'{__file__}/../../tests/test_3448-diff.png')
     diff.save(path_diff)
     print(f'{rms=}')
-    if pymupdf.mupdf_version_tuple < (1, 25, 5):
-        # Prior to fix for mupdf bug 708274.
-        assert 1 < rms < 2
-    else:
-        assert rms == 0
+    assert rms == 0
 
 
 def test_3854():
@@ -442,9 +434,6 @@ def test_3854():
         # MuPDF using external third-party libs gives slightly different
         # behaviour.
         assert rms < 2
-    elif pymupdf.mupdf_version_tuple < (1, 25, 5):
-        # # Prior to fix for mupdf bug 708274.
-        assert 0.5 < rms < 2
     else:
         assert rms == 0
 
@@ -558,14 +547,9 @@ def test_4423():
             print(f'Exception: {e}')
             ee = e
 
-        if (1, 25, 5) <= pymupdf.mupdf_version_tuple < (1, 26):
-            assert ee, f'Did not receive the expected exception.'
-            wt = pymupdf.TOOLS.mupdf_warnings()
-            assert wt == 'dropping unclosed output'
-        else:
-            assert not ee, f'Received unexpected exception: {e}'
-            wt = pymupdf.TOOLS.mupdf_warnings()
-            assert wt == 'format error: cannot find object in xref (56 0 R)\nformat error: cannot find object in xref (68 0 R)'
+        assert not ee, f'Received unexpected exception: {e}'
+        wt = pymupdf.TOOLS.mupdf_warnings()
+        assert wt == 'format error: cannot find object in xref (56 0 R)\nformat error: cannot find object in xref (68 0 R)'
 
 
 def test_4445():
@@ -587,10 +571,7 @@ def test_4445():
         pixmap = page.get_pixmap()
         print(f'{pixmap.width=}')
         print(f'{pixmap.height=}')
-        if pymupdf.mupdf_version_tuple >= (1, 26):
-            assert (pixmap.width, pixmap.height) == (792, 612)
-        else:
-            assert (pixmap.width, pixmap.height) == (612, 792)
+        assert (pixmap.width, pixmap.height) == (792, 612)
         if 0:
             path_pixmap = f'{path}.png'
             pixmap.save(path_pixmap)

tests/test_tables.py

@@ -184,13 +184,10 @@ def test_2979():
     ), f"{pymupdf.TOOLS.set_small_glyph_heights()=}"
 
     wt = pymupdf.TOOLS.mupdf_warnings()
-    if pymupdf.mupdf_version_tuple >= (1, 26, 0):
-        assert (
-            wt
-            == "bogus font ascent/descent values (3117 / -2463)\n... repeated 2 times..."
-        )
-    else:
-        assert not wt
+    assert (
+        wt
+        == "bogus font ascent/descent values (3117 / -2463)\n... repeated 2 times..."
+    )
 
 
 def test_3062():

tests/test_tesseract.py

@@ -18,10 +18,7 @@ def test_tesseract():
     path = os.path.abspath( f'{__file__}/../resources/2.pdf')
     doc = pymupdf.open( path)
     page = doc[5]
-    if pymupdf.mupdf_version_tuple < (1, 25, 4):
-        tail = 'OCR initialisation failed'
-    else:
-        tail = 'Tesseract language initialisation failed'
+    tail = 'Tesseract language initialisation failed'
     if os.environ.get('PYODIDE_ROOT'):
         e_expected = 'code=6: No OCR support in this build'
         e_expected_type = pymupdf.mupdf.FzErrorUnsupported
@@ -52,14 +49,6 @@ def test_tesseract():
                 assert type(e) == e_expected_type, f'{type(e)=} != {e_expected_type=}.'
         else:
             assert 0, f'Expected exception {e_expected!r}'
-        wt = pymupdf.TOOLS.mupdf_warnings()
-        if pymupdf.mupdf_version_tuple < (1, 25, 4):
-            assert wt == (
-                    'UNHANDLED EXCEPTION!\n'
-                    'library error: Tesseract initialisation failed'
-                    )
-        else:
-            assert not wt
 
 
 def test_3842b():
@@ -81,13 +70,7 @@ def test_3842b():
             if 'No tessdata specified and Tesseract is not installed' in str(e):
                 pass
             else:
-                if pymupdf.mupdf_version_tuple < (1, 25, 4):
-                    assert 'OCR initialisation failed' in str(e)
-                    wt = pymupdf.TOOLS.mupdf_warnings()
-                    assert wt == 'UNHANDLED EXCEPTION!\nlibrary error: Tesseract initialisation failed\nUNHANDLED EXCEPTION!\nlibrary error: Tesseract initialisation failed', \
-                            f'Unexpected {wt=}'
-                else:
-                    assert 'Tesseract language initialisation failed' in str(e)
+                assert 'Tesseract language initialisation failed' in str(e)
 
 
 def test_3842():

tests/test_textextract.py

@@ -446,16 +446,12 @@ def test_4147():
                         #print(f'        line')
                         for span in line['spans']:
                             #print(f'            span')
-                            if pymupdf.mupdf_version_tuple >= (1, 25, 2):
-                                #print(f'            span: {span["flags"]=:#x} {span["char_flags"]=:#x}')
-                                if expect_visible:
-                                    assert span['char_flags'] & pymupdf.mupdf.FZ_STEXT_FILLED
-                                else:
-                                    assert not (span['char_flags'] & pymupdf.mupdf.FZ_STEXT_FILLED)
-                                    assert not (span['char_flags'] & pymupdf.mupdf.FZ_STEXT_STROKED)
+                            #print(f'            span: {span["flags"]=:#x} {span["char_flags"]=:#x}')
+                            if expect_visible:
+                                assert span['char_flags'] & pymupdf.mupdf.FZ_STEXT_FILLED
                             else:
-                                #print(f'            span: {span["flags"]=:#x}')
-                                assert 'char_flags' not in span
+                                assert not (span['char_flags'] & pymupdf.mupdf.FZ_STEXT_FILLED)
+                                assert not (span['char_flags'] & pymupdf.mupdf.FZ_STEXT_STROKED)
                             # Check commit `add 'bidi' to span dict, add 'synthetic' to char dict.`
                             assert span['bidi'] == 0
                             for ch in span['chars']:
@@ -507,11 +503,7 @@ def test_4245():
     path_diff = os.path.normpath(f'{__file__}/../../tests/resources/test_4245_diff.png')
     pixmap_diff.save(path_diff)
     print(f'{rms=}')
-    if pymupdf.mupdf_version_tuple < (1, 25, 5):
-        # Prior to fix for mupdf bug 708274.
-        assert 0.1 < rms < 0.2
-    else:
-        assert rms < 0.01
+    assert rms < 0.01
 
 
 def test_4180():
@@ -532,11 +524,7 @@ def test_4180():
     path_diff = os.path.normpath(f'{__file__}/../../tests/resources/test_4180_diff.png')
     pixmap_diff.save(path_diff)
     print(f'{rms=}')
-    if pymupdf.mupdf_version_tuple < (1, 25, 5):
-        # Prior to fix for mupdf bug 708274.
-        assert 0.2 < rms < 0.3
-    else:
-        assert rms < 0.01
+    assert rms < 0.01
 
 
 def test_4182():
@@ -566,11 +554,7 @@ def test_4182():
     pixmap_diff.save(path_diff)
     rms = gentle_compare.pixmaps_rms(path_expected, pixmap)
     print(f'{rms=}')
-    if pymupdf.mupdf_version_tuple < (1, 25, 5):
-        # Prior to fix for mupdf bug 708274.
-        assert 3 < rms < 3.5
-    else:
-        assert rms < 0.01
+    assert rms < 0.01
 
 
 def test_4179():
@@ -655,11 +639,7 @@ def test_4179():
         pixmap_diff.save(path_out_diff)
         print(f'Have saved to: {path_out_diff=}')
         print(f'{rms=}')
-        if pymupdf.mupdf_version_tuple < (1, 25, 5):
-            # Prior to fix for mupdf bug 708274, our rects are rendered slightly incorrectly.
-            assert 3.5 < rms < 4.5
-        else:
-            assert rms < 0.01
+        assert rms < 0.01
 
     finally:
         pymupdf.TOOLS.set_aa_level(aa)