Filetype "txt" becomes the only supported value#4460
Closed
JorjMcKie wants to merge 3 commits into
Closed
Conversation
jamie-lemon
requested changes
Apr 21, 2025
After the introduction of a complete file content recognizer, the only relevant value for PyMuPDF's open parameter "filetype" remaining is "txt". This change will implement this such that specifying filetype="txt" will open files or memory data as plain text Documents. Other values will be silently ignored and no longer lead to confusing behavior.
JorjMcKie
force-pushed
the
restrict-open-with-filetype
branch
from
dd84cec to
0101907
Compare
Updating file open tests to reflect logic adjusted to file recognizer.
Collaborator
Author
|
Closing this as no longer relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the introduction of a complete file content recognizer, the only remaining relevant value for PyMuPDF's open parameter "filetype" is "txt". This change will implement this such that specifying filetype="txt" will open files or memory data as plain text Documents. Other values will be silently ignored and no longer lead to confusing behavior.