Address 4520#4523
Merged
Merged
Conversation
julian-smith-artifex-com
approved these changes
May 26, 2025
We previously refused the use of a page without a /Contents object as source page in method `show_pdf_page`. We now simply assume an empty stream and still create the Form XObject in the target PDF.
e5965ea to
5fff706
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously refused a source page without a /Contents object in method
show_pdf_page.This fix creates a Form XObject in the target PDF with a stream length of 0 in this case.