Skip to content

Adapt tests to fewer bogus font ascent/descent value warnings. #4777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebras merged 1 commit into from
Nov 6, 2025
Merged

Adapt tests to fewer bogus font ascent/descent value warnings. #4777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/test_clip_page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ def test_clip():
page = doc[0]
page.clip_to_rect(rect) # clip the page to the rectangle
# capture font warning message of MuPDF
assert pymupdf.TOOLS.mupdf_warnings() == "bogus font ascent/descent values (0 / 0)"
if pymupdf.mupdf_version_tuple < (1, 27):
assert pymupdf.TOOLS.mupdf_warnings() == "bogus font ascent/descent values (0 / 0)"
# extract all text characters and assert that each one
# has a non-empty intersection with the rectangle.
chars = [
Expand Down
3 changes: 2 additions & 1 deletion tests/test_font.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,4 +337,5 @@ def test_4457():
# Avoid test failure caused by mupdf warnings.
wt = pymupdf.TOOLS.mupdf_warnings()
print(f'{wt=}')
assert wt == 'bogus font ascent/descent values (0 / 0)\n... repeated 5 times...'
if pymupdf.mupdf_version_tuple < (1, 27):
assert wt == 'bogus font ascent/descent values (0 / 0)\n... repeated 5 times...'
16 changes: 5 additions & 11 deletions tests/test_general.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,8 @@ def test_iswrapped():
doc = pymupdf.open(filename)
page = doc[0]
assert page.is_wrapped
wt = pymupdf.TOOLS.mupdf_warnings()
if pymupdf.mupdf_version_tuple >= (1, 26, 0):
assert wt == 'bogus font ascent/descent values (0 / 0)'
else:
assert not wt
if (1, 26, 0) <= pymupdf.mupdf_version_tuple < (1, 27):
assert pymupdf.TOOLS.mupdf_warnings() == 'bogus font ascent/descent values (0 / 0)'


def test_wrapcontents():
Expand All @@ -82,7 +79,7 @@ def test_wrapcontents():
rebased = hasattr(pymupdf, 'mupdf')
if rebased:
wt = pymupdf.TOOLS.mupdf_warnings()
if pymupdf.mupdf_version_tuple >= (1, 26, 0):
if (1, 26, 0) <= pymupdf.mupdf_version_tuple < (1, 27):
assert wt == 'bogus font ascent/descent values (0 / 0)\nPDF stream Length incorrect'
else:
assert wt == 'PDF stream Length incorrect'
Expand Down Expand Up @@ -246,11 +243,8 @@ def test_get_text_dict():
blocks=page.get_text("dict")["blocks"]
# Check no opaque types in `blocks`.
json.dumps( blocks, indent=4)
wt = pymupdf.TOOLS.mupdf_warnings()
if pymupdf.mupdf_version_tuple >= (1, 26, 0):
assert wt == 'bogus font ascent/descent values (0 / 0)'
else:
assert not wt
if (1, 26, 0) <= pymupdf.mupdf_version_tuple < (1, 27):
assert pymupdf.TOOLS.mupdf_warnings() == 'bogus font ascent/descent values (0 / 0)'

def test_font():
font = pymupdf.Font()
Expand Down
6 changes: 3 additions & 3 deletions tests/test_pixmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def product(x, y):
else:
assert rms == 0
wt = pymupdf.TOOLS.mupdf_warnings()
if pymupdf.mupdf_version_tuple >= (1, 26, 0):
if (1, 26, 0) <= pymupdf.mupdf_version_tuple < (1, 27):
assert wt == 'bogus font ascent/descent values (0 / 0)\nPDF stream Length incorrect'
else:
assert wt == 'PDF stream Length incorrect'
Expand Down Expand Up @@ -523,8 +523,8 @@ def test_4435():
print(f'Calling page.get_pixmap().', flush=1)
pixmap = page.get_pixmap(alpha=False, dpi=120)
print(f'Called page.get_pixmap().', flush=1)
wt = pymupdf.TOOLS.mupdf_warnings()
assert wt == 'bogus font ascent/descent values (0 / 0)\n... repeated 9 times...'
if pymupdf.mupdf_version_tuple < (1, 27):
assert pymupdf.TOOLS.mupdf_warnings() == 'bogus font ascent/descent values (0 / 0)\n... repeated 9 times...'


def test_4423():
Expand Down