Support _retain_test_patterns key for prebuilt wheels as sources in recipes#288
Merged
Merged
Conversation
agriyakhetarpal
added
the
integration
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted in pyodide/pyodide-recipes#484. Since we unvendor the tests from prebuilt wheel packages before
--installing them anyway, I think we should also support the_retain-test-patternsflag for prebuilt wheels too. This PR updates the logic for unvendoring tests – so if we ask to retain test patterns, we process the files one-by-one instead of moving entiretests/folders. I added a recipe as an integration test, using a simple package likecolorama(I couldn't find any better candidates in my narrow and limited search).