Compile compression.zstd as added in CPython 3.14#6240
Conversation
|
Okay, this is passing in the I guess I just need to update the CHANGELOG, but maybe we should also document that we should periodically look at https://github.com/python/cpython-source-deps and update it too, to stay in sync with CPython. I'll do in my evening later today, but till that time, this is ready for review. Thanks! |
|
So it looks like this adds ~10KB to asm.mjs and ~200KB to asm.wasm (compressed). It is not a blocker for this PR, but maybe worth remembering. |
ryanking13
left a comment
There was a problem hiding this comment.
Thanks! Could you check the gha failure? I don't think it is related to this PR, but it seems like GHA or conda changed something recently, making the build fail.
|
Thanks! Fixed in #6241. I think we can go further and reduce the size a bit. Let me try! |
|
Our size-checking script reports no size increase because we report it in KB and it rounds off the increase, effectively hiding it. So I checked: I downloaded on
|
Description
xref #6233, #6033, #5995. This PR adds the
compression.zstdmodule which is now available in Python 3.14, but we weren't including it.I caught this while working on zarr-developers/numcodecs#529 locally as part of a dependency that used the module, but I couldn't import it.
Checklist