selenium_jspi: don't pass experimental flag with chrome >= 137#167
Open
hoodmane wants to merge 4 commits into
Open
selenium_jspi: don't pass experimental flag with chrome >= 137#167hoodmane wants to merge 4 commits into
hoodmane wants to merge 4 commits into
Conversation
JSPI is enabled by default in this case
hoodmane
changed the title
ryanking13
reviewed
Jul 22, 2025
Comment on lines
+452
to
+456
| driver = Chrome(options=options) | ||
| chrome_version = int( | ||
| driver.capabilities.get("browserVersion", "0").split(".")[0] | ||
| ) | ||
| driver.quit() |
Member
There was a problem hiding this comment.
I am curious how expensive it is to initialize a Chrome instance here. If it actually runs a new Chrome browser, it would be nice if we can cache the value somewhere instead of calling it everytime in get_driver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSPI is enabled by default in this case.
Resolves #163.